Skip to content

Conversation

@svenvh
Copy link
Member

@svenvh svenvh commented Oct 21, 2024

Add the defines for the cl_ext_image_unorm_int_2_101010_EXT extension.

Add the defines for the `cl_ext_image_unorm_int_2_101010_EXT`
extension.
@svenvh
Copy link
Member Author

svenvh commented Oct 21, 2024

Extension specification: KhronosGroup/OpenCL-Docs#1223

@llvmbot llvmbot added clang Clang issues not falling into any other category backend:X86 clang:headers Headers provided by Clang, e.g. for intrinsics labels Oct 21, 2024
@svenvh svenvh requested a review from kpet October 21, 2024 10:21
@llvmbot
Copy link
Member

llvmbot commented Oct 21, 2024

@llvm/pr-subscribers-backend-x86

@llvm/pr-subscribers-clang

Author: Sven van Haastregt (svenvh)

Changes

Add the defines for the cl_ext_image_unorm_int_2_101010_EXT extension.


Full diff: https://github.com/llvm/llvm-project/pull/113145.diff

2 Files Affected:

  • (modified) clang/lib/Headers/opencl-c-base.h (+4)
  • (modified) clang/test/Headers/opencl-c-header.cl (+6)
diff --git a/clang/lib/Headers/opencl-c-base.h b/clang/lib/Headers/opencl-c-base.h
index 786678b9d8a753..b6bcf32c09c08c 100644
--- a/clang/lib/Headers/opencl-c-base.h
+++ b/clang/lib/Headers/opencl-c-base.h
@@ -46,6 +46,7 @@
 #define __opencl_c_ext_fp32_global_atomic_min_max 1
 #define __opencl_c_ext_fp32_local_atomic_min_max 1
 #define __opencl_c_ext_image_raw10_raw12 1
+#define __opencl_c_ext_image_unorm_int_2_101010 1
 #define cl_khr_kernel_clock 1
 #define __opencl_c_kernel_clock_scope_device 1
 #define __opencl_c_kernel_clock_scope_work_group 1
@@ -486,6 +487,9 @@ typedef enum memory_order
 #define CLK_UNSIGNED_INT_RAW10_EXT 0x10E3
 #define CLK_UNSIGNED_INT_RAW12_EXT 0x10E4
 #endif // __opencl_c_ext_image_raw10_raw12
+#ifdef __opencl_c_ext_image_unorm_int_2_101010
+#define CLK_UNORM_INT_2_101010_EXT 0x10E5
+#endif // __opencl_c_ext_image_unorm_int_2_101010
 
 // Channel order, numbering must be aligned with cl_channel_order in cl.h
 //
diff --git a/clang/test/Headers/opencl-c-header.cl b/clang/test/Headers/opencl-c-header.cl
index 7c4c673cf2ee07..7317ff0adaafb3 100644
--- a/clang/test/Headers/opencl-c-header.cl
+++ b/clang/test/Headers/opencl-c-header.cl
@@ -190,6 +190,9 @@ global atomic_int z = ATOMIC_VAR_INIT(99);
 #if __opencl_c_ext_image_raw10_raw12 != 1
 #error "Incorrectly defined __opencl_c_ext_image_raw10_raw12"
 #endif
+#if __opencl_c_ext_image_unorm_int_2_101010 != 1
+#error "Incorrectly defined __opencl_c_ext_image_unorm_int_2_101010"
+#endif
 
 #else
 
@@ -277,6 +280,9 @@ global atomic_int z = ATOMIC_VAR_INIT(99);
 #ifdef __opencl_c_ext_image_raw10_raw12
 #error "Incorrect __opencl_c_ext_image_raw10_raw12 define"
 #endif
+#ifdef __opencl_c_ext_image_unorm_int_2_101010
+#error "Incorrect __opencl_c_ext_image_unorm_int_2_101010 define"
+#endif
 
 #endif //(defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200)
 

Copy link
Collaborator

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kpet
Copy link
Collaborator

kpet commented Oct 21, 2024

AFAICT, the new tests ran and the failed tests are completely unrelated to this change. Merging.

@kpet kpet merged commit 6201bcc into llvm:main Oct 21, 2024
10 of 12 checks passed
@svenvh svenvh deleted the cl_ext_image_unorm_int_2_101010_EXT branch October 22, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:X86 clang:headers Headers provided by Clang, e.g. for intrinsics clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants