Fix return value of 'PluginManager::RegisterPlugin()'.

[mbucko]

No description provided.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Miro Bucko (mbucko)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/114120.diff

1 Files Affected:

• (modified) lldb/source/Core/PluginManager.cpp (+1-1)

diff --git a/lldb/source/Core/PluginManager.cpp b/lldb/source/Core/PluginManager.cpp
index a5219025495a91..50bbfba33ee512 100644
--- a/lldb/source/Core/PluginManager.cpp
+++ b/lldb/source/Core/PluginManager.cpp
@@ -209,7 +209,7 @@ template <typename Instance> class PluginInstances {
     Instance instance =
         Instance(name, description, callback, std::forward<Args>(args)...);
     m_instances.push_back(instance);
-    return false;
+    return true;
   }
 
   bool UnregisterPlugin(typename Instance::CallbackType callback) {

[JDevlieghere]

While you're here... :-) Should this use emplace_back to create the instance object in place?

[jimingham]

We obviously aren't checking this return anywhere. The only way it can return false that I can see is if you call RegisterPlugin with no callback pointer - which seems more like a programming error than a run-time check. Do we actually need this bool return?

[mbucko]

We obviously aren't checking this return anywhere. The only way it can return false that I can see is if you call RegisterPlugin with no callback pointer - which seems more like a programming error than a run-time check. Do we actually need this bool return?

It is indeed being checked in many places, I tried removing it and the compiler was not happy :)