-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Closed
Labels
Description
The DxilOpLower pass does not apply attributes indicated by DXIL.td. In addition, the DXIL Op tablegen emitter doesn't properly include multiple attributes for the Op as it tries to OR them together like stages. Attribute values aren't represented as single bit values, so this won't work. Instead we need to represent them as a simplevector of attribute values. These will need to be read in DxilOpLower and assigned to the output dxilop calls.
AC:
- Update
DXILEmitter.cppto emit attributes as a list - Update
DXILOpBuilder.cppto set these attributes on the generated DXIL op - Update
DXILEmitter.cppandDXILOpBuilder.cppto make sureReadOnlyandReadNonegenerate the right memory function attribute. - Update testcases in
llvm/test/CodeGen/DirectXto ensure correct attribute generation
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Closed