Correct Printing of Pointers and References to Vectors

[pow2clk]

The order in which vector type elements are printed results in the * or & operand being placed such that it might be interpreted not as a pointer to a vector, but as a vector of pointers to the element type. See this example in the diagnostic output and potentially follow this discussion that motivated the issue.

The solution is pretty simple and involves printing most of the vector elements in the Before function. This will impact a few tests that depend on the current ordering where, rather than the __private qualifier such as in this OpenCL test.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Greg Roth (pow2clk)

The order in which vector type elements are printed results in the `*` or `&` operand being placed such that it might be interpreted not as a pointer to a vector, but as a vector of pointers to the element type. See this [example](https://godbolt.org/z/jqa3d3n4K) in the diagnostic output and potentially follow this [discussion](https://github.com//pull/111415#discussion_r1795133310) that motivated the issue.

The solution is pretty simple and involves printing most of the vector elements in the Before function. This will impact a few tests that depend on the current ordering where, rather than the __private qualifier such as in this OpenCL test.

[damyanp]

Although this is likely a quick change to make it will require getting consensus from a broad set of people so it'll likely take a long time to complete on the calendar.