[llvm] optionally install backend headers #115837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The story and reasoning behind this commit: https://discourse.llvm.org/t/installing-target-specific-headers-for-out-of-tree-usage/83080 |
Currently, LLVM provides no way to access target-specific headers out-of-tree. This makes it practically impossible to use LLVM for instructions descriptions outside llvm-project repository and forces people to clone llvm and build all of it alongside their project. Or copy LLVM .tb files and run llvm-tblgen on them by hand. This commit adds a cmake option to install those headers alongside other llvm headers which makes it possible to use llvm backend headers out of llvm-project tree. Co-authored-by: Sergei Zimmerman <[email protected]>
Collaborator
|
I'm not really a fan of complicating our build by supporting this configuration, but that isn't a strongly held opinion. Looping in some other contributors with build expertise: @petrhosek & @compnerd. |
compnerd
reviewed
Nov 15, 2024
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
I'm not sure how I feel about this change. I can see the value for out-of-tree clients. However, there are no ABI guarantees and there is no library versioning. As long as these are paired with a static library it might be okay.
How do we ensure that the transitive closure is captured and nothing accidentally is left out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, LLVM provides no way to access target-specific headers out-of-tree. This makes it practically impossible to use LLVM for instructions descriptions outside llvm-project repository and forces people to clone llvm and build all of it alongside their project. Or copy LLVM .tb files and run llvm-tblgen on them by hand. This commit adds a cmake option to install those headers alongside other llvm headers which makes it possible to use llvm backend headers out of llvm-project tree.