[LSAN] Add extra suppressions on Apple Aarch64

[madsmtm]

• _fetchInitializingClassList for startup code in dyld.
• dyld4::RuntimeState::_instantiateTLVs for thread locals.

Fixes #115992, now it shows the following instead (in a project using thread locals):

-----------------------------------------------------
Suppressions used:
  count      bytes template
      3        120 *_fetchInitializingClassList*
      1        104 *dyld4::RuntimeState::_instantiateTLVs*
-----------------------------------------------------

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Mads Marquart (madsmtm)

Changes

• _fetchInitializingClassList for startup code in dyld.
• dyld4::RuntimeState::_instantiateTLVs for thread locals.

Fixes #115992.

---

Full diff: https://github.com/llvm/llvm-project/pull/117478.diff

1 Files Affected:

• (modified) compiler-rt/lib/lsan/lsan_common.cpp (+7)

diff --git a/compiler-rt/lib/lsan/lsan_common.cpp b/compiler-rt/lib/lsan/lsan_common.cpp
index 7ab9e4ff2ac9fd..56b943fa05b459 100644
--- a/compiler-rt/lib/lsan/lsan_common.cpp
+++ b/compiler-rt/lib/lsan/lsan_common.cpp
@@ -120,7 +120,14 @@ static const char kStdSuppressions[] =
 #  endif  // SANITIZER_SUPPRESS_LEAK_ON_PTHREAD_EXIT
 #  if SANITIZER_APPLE
     // For Darwin and os_log/os_trace: https://reviews.llvm.org/D35173
+#   if SANITIZER_ARM64
+    // Apple Aarch64 leaks on startup in _fetchInitializingClassList and when
+    // using thread locals in dyld4::RuntimeState::_instantiateTLVs.
+    // See https://github.com/llvm/llvm-project/issues/115992.
+    "leak:*_os_trace*\nleak:*_fetchInitializingClassList*\nleak:*dyld4::RuntimeState::_instantiateTLVs*\n"
+#   else
     "leak:*_os_trace*\n"
+#   endif
 #  endif
     // TLS leak in some glibc versions, described in
     // https://sourceware.org/bugzilla/show_bug.cgi?id=12650.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[hkratz]

FYI: _fetchInitializingClassList is actually related to some special-cased thread locals as well, the allocation is here, _objc_fetch_pthread_data has the TLS access.

[calvin2021y]

Is this will merge into 19.1.6 ?

[epiciskandar]

hope this could be merged, the problem is still exists.

[madsmtm]

CC @vitalybuka, could you review this?

(Also, I can't merge myself if you think this is fine).

[wrotki]

LGTM , we know LSAN doesn't work well on AS, tracked here: #131678