[Clang][AST Matchers] Missing attributedStmt AST matcher

[DistinctWind]

Currently I'm playing with AST Transformer and I want to transform certain attributed statements. In the first step, I need to match the attributed statements. However, I didn't find any AST Matcher that will match AST Nodes AttributedStmt, AnnotateAttr and its corresponding statement in ASTMatchers.h.

I found a code review from the old llvm review platform, which is well discussed and approved. But it doesn't appear in current llvm 20 git build and I can't find any related Github Issue.

I wounder if it's forgot for some reason. Clang 20 now supports adding custom attribute in a plugin, so I think it's also a point to add support for matching AttributedStmt nodes.

[AaronBallman]

Generally speaking, we only add ast matchers to ASTMatchers.h when there's enough uses of it to justify the cost (because that file is extremely expensive to compile due to the amount of template instantiations it generates). Otherwise, we let folks define local matchers (e.g.,

llvm-project/clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp

Line 22 in 89b31c9

AST_MATCHER_P(QualType, hasCleanType, ast_matchers::internal::Matcher<QualType>,

) until there is enough reason to surface the matcher more generally.

Would a local matcher suffice for you?

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Distinct Wind (DistinctWind)

Currently I'm playing with AST Transformer and I want to transform certain attributed statements. In the first step, I need to match the attributed statements. However, I didn't find any AST Matcher that will match AST Nodes `AttributedStmt`, `AnnotateAttr` and its corresponding statement in ASTMatchers.h.

I found a code review from the old llvm review platform, which is well discussed and approved. But it doesn't appear in current llvm 20 git build and I can't find any related Github Issue.

I wounder if it's forgot for some reason. Clang 20 now supports adding custom attribute in a plugin, so I think it's also a point to add support for matching AttributedStmt nodes.

[DistinctWind]

So there's a way to define local AST matcher, that will be great.

I'll try to learn how to define a local AST matcher that finds an AttrubutedStmt, and later post that working code snippet here to help others who also come up with this problem.

[AaronBallman]

So there's a way to define local AST matcher, that will be great.

I'll try to learn how to define a local AST matcher that finds an AttrubutedStmt, and later post that working code snippet here to help others who also come up with this problem.

FWIW, that matcher would look like:

extern const internal::VariadicDynCastAllOfMatcher<Stmt, AttributedStmt> attributedStmt;

I'm going to close this issue as not planned, but if there's a need to upstream this matcher, feel free to reopen the issue with more details about those needs.