[Clang] --dump-config option returns default configuration

[NahuFigueroa97]

I'm using the -style=file option to find the .clang-format in the same directory or higher, while I use the --dump-config option to check that it takes the indicated options, but it always returns the default options. It's strange because if I modify my own .clang-format incorrectly, it tells me the error so I assume it's finding the file correctly. This happens in both versions 14 and 18.

clang-format-14 -i example/src/fieldAlertHelper.hpp --style=file --dump-config

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Nahuel Figueroa (NahuFigueroa97)

I'm using the -style=file option to find the .clang-format in the same directory or higher, while I use the --dump-config option to check that it takes the indicated options, but it always returns the default options. It's strange because if I modify my own .clang-format incorrectly, it tells me the error so I assume it's finding the file correctly. This happens in both versions 14 and 18.

clang-format-14 -i example/src/fieldAlertHelper.hpp --style=file --dump-config

[EugeneZelenko]

Could you please try 19 or main branch?

[NahuFigueroa97]

I get the same results. If I put a wrong configuration, it warns me. But with --dump-config it shows me the default file.

--dump-config Should I show the default file or the file I used during execution? It always shows me the default one

[owenca]

I'm using the -style=file option to find the .clang-format in the same directory or higher, while I use the --dump-config option to check that it takes the indicated options, but it always returns the default options. It's strange because if I modify my own .clang-format incorrectly, it tells me the error so I assume it's finding the file correctly. This happens in both versions 14 and 18.

What's your .clang-format file? What options you changed were not reflected by -dump-config?

[NahuFigueroa97]

This is my .clang-format

...
AccessModifierOffset: '-4'
AlignAfterOpenBracket: Align
AlignConsecutiveAssignments: 'false'
AlignConsecutiveDeclarations: 'false'
AlignConsecutiveMacros: 'true'
AlignEscapedNewlines: Right
AlignOperands: 'true'
AlignTrailingComments: 'true'
AllowAllArgumentsOnNextLine: 'true'
AllowAllConstructorInitializersOnNextLine: 'true'
AllowAllParametersOfDeclarationOnNextLine: 'true'
AllowShortBlocksOnASingleLine: 'false'
AllowShortCaseLabelsOnASingleLine: 'true'
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: Never
AllowShortLambdasOnASingleLine: Inline
AllowShortLoopsOnASingleLine: 'true'
AlwaysBreakBeforeMultilineStrings: 'false'
AlwaysBreakTemplateDeclarations: 'Yes'
BinPackArguments: 'false'
BinPackParameters: 'false'
BreakBeforeBinaryOperators: NonAssignment
BreakBeforeBraces: Allman
BreakConstructorInitializers: BeforeComma
BreakInheritanceList: BeforeComma
ColumnLimit: 120
Cpp11BracedListStyle: 'true'
FixNamespaceComments: 'true'
IncludeBlocks: Preserve
IndentCaseLabels: 'true'
IndentWidth: '4'
PointerAlignment: Left
SortIncludes: 'true'
SpaceAfterCStyleCast: 'false'
SpaceAfterLogicalNot: 'false'
SpaceAfterTemplateKeyword: 'false'
SpaceBeforeAssignmentOperators: 'true'
SpaceBeforeCpp11BracedList: 'true'
SpaceBeforeCtorInitializerColon: 'true'
SpaceBeforeInheritanceColon: 'true'
SpaceBeforeParens: ControlStatements
SpaceInEmptyParentheses: 'false'
SpacesInAngles: 'false'
Standard: Auto
TabWidth: '4'
UseTab: Never
---
Language: Proto
DisableFormat: false

[NahuFigueroa97]

I see that it modifies the options I have in my file and leaves the others intact. This is a problem because when I run clang-14 and apply the changes, if I then run clang-18 it reapplies changes to what clang-14 had corrected.
In this line for example:

template<typename T>
nlohmann::json fillEmptyOrNegative(T&& field)
{
    if constexpr (std::is_same_v<std::remove_cv_t<std::remove_reference_t<T>>, std::string_view>
                  || std::is_same_v<T, std::string>)

clang-format-14

template<typename T>
nlohmann::json fillEmptyOrNegative(T&& field)
{
    if constexpr (std::is_same_v<std::remove_cv_t<std::remove_reference_t<T>>,
                                 std::string_view> || std::is_same_v<T, std::string>)

clang-format-18

template<typename T>
nlohmann::json fillEmptyOrNegative(T&& field)
{
    if constexpr (std::is_same_v<std::remove_cv_t<std::remove_reference_t<T>>, std::string_view>
                  || std::is_same_v<T, std::string>)

In short, clang-format-14 reports errors to me:

src/fieldAlertHelper.hpp:33:79: warning: code should be clang-formatted [-Wclang-format-violations]
    if constexpr (std::is_same_v<std::remove_cv_t<std::remove_reference_t<T>>, std::string_view>
                                                                              ^
src/fieldAlertHelper.hpp:33:97: warning: code should be clang-formatted [-Wclang-format-violations]
    if constexpr (std::is_same_v<std::remove_cv_t<std::remove_reference_t<T>>, std::string_view>
                                                                                                ^
src/fieldAlertHelper.hpp:58:85: warning: code should be clang-formatted [-Wclang-format-violations]
        static_assert(std::is_arithmetic_v<std::remove_cv_t<std::remove_reference_t<T>>>
                                                                                    ^
src/fieldAlertHelper.hpp:58:89: warning: code should be clang-formatted [-Wclang-format-violations]
        static_assert(std::is_arithmetic_v<std::remove_cv_t<std::remove_reference_t<T>>>
                                                                                        ^

while clang-format-18 does not

[owenca]

This is my .clang-format

...
AccessModifierOffset: '-4'
AlignAfterOpenBracket: Align
AlignConsecutiveAssignments: 'false'
AlignConsecutiveDeclarations: 'false'
AlignConsecutiveMacros: 'true'
AlignEscapedNewlines: Right
AlignOperands: 'true'
AlignTrailingComments: 'true'
AllowAllArgumentsOnNextLine: 'true'
AllowAllConstructorInitializersOnNextLine: 'true'
AllowAllParametersOfDeclarationOnNextLine: 'true'
AllowShortBlocksOnASingleLine: 'false'
AllowShortCaseLabelsOnASingleLine: 'true'
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: Never
AllowShortLambdasOnASingleLine: Inline
AllowShortLoopsOnASingleLine: 'true'
AlwaysBreakBeforeMultilineStrings: 'false'
AlwaysBreakTemplateDeclarations: 'Yes'
BinPackArguments: 'false'
BinPackParameters: 'false'
BreakBeforeBinaryOperators: NonAssignment
BreakBeforeBraces: Allman
BreakConstructorInitializers: BeforeComma
BreakInheritanceList: BeforeComma
ColumnLimit: 120
Cpp11BracedListStyle: 'true'
FixNamespaceComments: 'true'
IncludeBlocks: Preserve
IndentCaseLabels: 'true'
IndentWidth: '4'
PointerAlignment: Left
SortIncludes: 'true'
SpaceAfterCStyleCast: 'false'
SpaceAfterLogicalNot: 'false'
SpaceAfterTemplateKeyword: 'false'
SpaceBeforeAssignmentOperators: 'true'
SpaceBeforeCpp11BracedList: 'true'
SpaceBeforeCtorInitializerColon: 'true'
SpaceBeforeInheritanceColon: 'true'
SpaceBeforeParens: ControlStatements
SpaceInEmptyParentheses: 'false'
SpacesInAngles: 'false'
Standard: Auto
TabWidth: '4'
UseTab: Never
---
Language: Proto
DisableFormat: false

So which of the above options has a value different (or not equivalent to) the one printed by -dump-config? Please try version 19 or the main branch.