[NFC] Eliminate need of Emacs tag and file name in file header #118553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify file header to not require file name and C++ Emacs tag. See https://discourse.llvm.org/t/is-c-in-header-files-still-relevant/83124/1
Contributor
Author
|
@nikic and @AaronBallman PTAL at the discourse thread above and see if we want to make this amendment to the coding standards. This does not mean that all files will be immediately updated to strip out the current header, but over time. |
nikic
approved these changes
Dec 4, 2024
Contributor
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
LGTM, the discourse thread has a clear consensus that the emacs marker is no longer necessary, and the file name and impracticably short description are not useful.
jurahul
changed the title
Contributor
Author
|
Thanks. @AaronBallman will wait a couple of days to give you a chance to look as well. Will merge towards EOW. |
vbvictor
added a commit
that referenced
this pull request
Aug 18, 2025
After #118553, emacs tag is no longer needed in LLVM files: https://llvm.org/docs/CodingStandards.html#file-headers. This patch removes it from `add_new_check.py` lowering complexity we need to maintain.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 18, 2025
…s (#153942) After llvm/llvm-project#118553, emacs tag is no longer needed in LLVM files: https://llvm.org/docs/CodingStandards.html#file-headers. This patch removes it from `add_new_check.py` lowering complexity we need to maintain.
localspook
added a commit
that referenced
this pull request
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discourse.llvm.org/t/is-c-in-header-files-still-relevant/83124/1