[libc] Stop installing sys/types.h when not requested
#119765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is installed unconditionally because of the dependency in the `hdr/` directory. Remove this so it's only used on the systems that need it.
Member
|
@llvm/pr-subscribers-libc Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/119765.diff 1 Files Affected:
diff --git a/libc/hdr/types/CMakeLists.txt b/libc/hdr/types/CMakeLists.txt
index 68a0e9603f9752..ce3ecefe364383 100644
--- a/libc/hdr/types/CMakeLists.txt
+++ b/libc/hdr/types/CMakeLists.txt
@@ -137,7 +137,6 @@ add_proxy_header_library(
clockid_t.h
FULL_BUILD_DEPENDS
libc.include.llvm-libc-types.clockid_t
- libc.include.sys_types
)
add_proxy_header_library(
@@ -173,7 +172,6 @@ add_proxy_header_library(
pid_t.h
FULL_BUILD_DEPENDS
libc.include.llvm-libc-types.pid_t
- libc.include.sys_types
)
add_proxy_header_library(
|
lntue
approved these changes
Dec 12, 2024
Member
|
Right, the headers are only generated for fullbuild. The proxy headers fall back to sys/types.h when in overlay mode. LGTM |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/17427 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is installed unconditionally because of the dependency in the
hdr/directory. Remove this so it's only used on the systems that needit.