[flang] Enable loop-versioning for slices. #120344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang
tblah
approved these changes
Dec 18, 2024
Contributor
tblah
left a comment
tblah
left a comment
There was a problem hiding this comment.
LGTM, but please wait for @Leporacanthicus
Loops resulting from array expressions like array(:,i) may be versioned for the unit stride of the innermost dimension, when the initial array is an assumed-shape array (which are contiguous in many Fortran programs). This speeds up facerec for about 12% due to further vectorization of the innermost loop produced for the total SUM reduction.
vzakhari
force-pushed
the
loop_version_slices
branch
from
dfc81b4 to
0f6cb87
Compare
Contributor
Author
|
Friendly ping @Leporacanthicus |
Contributor
Mats might have missed this. You can go ahead and Mats can do a post-commit review if required. |
Leporacanthicus
approved these changes
Dec 23, 2024
Contributor
Leporacanthicus
left a comment
Leporacanthicus
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for doing this. And appologies for the slow response, I completely missed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loops resulting from array expressions like array(:,i)
may be versioned for the unit stride of the innermost dimension,
when the initial array is an assumed-shape array (which are contiguous
in many Fortran programs).
This speeds up facerec for about 12% due to further vectorization
of the innermost loop produced for the total SUM reduction.