[clang-tidy] Check request: modernize-use-stoi-instead-atoi

[denzor200]

std::string str = "42";
int a = std::atoi(str.c_str()); // INCORRECT
int b = std::stoi(str); //  OK

Since std::atoi is ancient and might produce bugs in overflow cases.

[firewave]

This is not a drop-in replacement as they behave very differently.

[firewave]

This also already exists as cert-err34-c.

[denzor200]

This also already exists as cert-err34-c.

Oke, got it. Thanks for the information!

[denzor200]

This also already exists as cert-err34-c.

Can we create alias for that check in modernize section? I didn't know that this check exists before I created this issue

[seanm]

Can we create alias for that check in modernize section? I didn't know that this check exists before I created this issue

You might want to take a subtractive approach, and enable all checks, then disable those you don't want/need. Then you can discover all checks.