[libc] missing .note.GPU-stack section in fake_heap.s

[nickdesaulniers]

Building llvm-libc unit tests with ld.bfd, I observe the warning:

/usr/bin/ld: warning: libc/test/src/__support/CMakeFiles/libc.test.src.__support.freelist_heap_test.__unit__.__build__.dir/fake_heap.s.o: missing .note.GNU-stack section implies executable stack

There's a command line flag for the compiler for this; but also I think you can use assembler directives in the assembler sources, too.

[llvmbot]

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Building llvm-libc unit tests with ld.bfd, I observe the warning:

/usr/bin/ld: warning: libc/test/src/__support/CMakeFiles/libc.test.src.__support.freelist_heap_test.__unit__.__build__.dir/fake_heap.s.o: missing .note.GNU-stack section implies executable stack

There's a command line flag for the compiler for this; but also I think you can use assembler directives in the assembler sources, too.

[nickdesaulniers]

There's also:

[2787/6972] Building ASM object libc/test/src/__support/CM...rt.freelist_heap_test.__unit__.__build__.dir/fake_heap.s.o
clang: warning: argument unused during compilation: '-D LIBC_NAMESPACE=__llvm_libc_20_0_0_git' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-isystem /android0/llvm-project/build/libc/include' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-O3' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-D NDEBUG' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-D LIBC_FULL_BUILD' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-ffreestanding' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-fno-unwind-tables' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-fno-asynchronous-unwind-tables' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-ffixed-point' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-MD' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-MT libc/test/src/__support/CMakeFiles/libc.test.src.__support.freelist_heap_test.__unit__.__build__.dir/fake_heap.s.o' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-MF libc/test/src/__support/CMakeFiles/libc.test.src.__support.freelist_heap_test.__unit__.__build__.dir/fake_heap.s.o.d' [-Wunused-command-line-argument]

which is likely because we're using C flags for .s files.

[mysterymath]

Sorry about missing this issue; sent #136634 for this.