[bazel] Replace strip_include_prefix in lldb with includes #125293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupprecht
approved these changes
Jan 31, 2025
These both have the same result that the relevant include paths are propagated to all dependents, but includes is dedup'd where strip_include_prefix is not. So this reduces 17 include paths for all transitive dependents.
keith
force-pushed
the
ks/bazel-replace-strip_include_prefix-in-lldb-with-includes
branch
from
2092bba to
5a70c17
Compare
Member
Author
|
added some more, now removes >100 include paths because of all the plugins |
keith
deleted the
ks/bazel-replace-strip_include_prefix-in-lldb-with-includes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These both have the same result that the relevant include paths are
propagated to all dependents, but includes is dedup'd where
strip_include_prefix is not. So this reduces >100 include paths for all
transitive dependents.