-
Notifications
You must be signed in to change notification settings - Fork 15k
Closed
Labels
HLSLHLSL Language SupportHLSL Language Supportclang:frontendLanguage frontend issues, e.g. anything involving "Sema"Language frontend issues, e.g. anything involving "Sema"
Description
This issue handles the additional semantic analysis of the parsed HLSLRootSignature attribute. This includes generating applicable diagnostics.
The relevant validations that this issue must implement are:
- Ensure valid flag combinations of
DESCRIPTOR_RANGE_FLAGSandROOT_DESCRIPTOR_FLAGS - Ensure valid values of
DESCRIPTOR_RANGE_FLAGSfor theSamplerdescriptor table clause - Ensure that listed parameters of
StaticSamplerare bounded correctly - Validate that the
spaceparameter is not in the invalid range of0xFFFFFFF0to0xFFFFFFFF - Validate that the
numDescriptorsparameter is not 0. - Ensure that the correct register type matches the desriptor range type - this is handled during parsing
AC:
- Update
ParseHLSLRootSignaturedefined in [HLSL] Generate AST for Root Signatures #119011 to implement semantic validation ofHLSLRootSignature - Update
handleHLSLRootSignatureto implement semantic validation ofHLSLRootSignatureinSemaHLSL.cpp - Add thorough testing of correct diagnostics into
clang/unittests/Sema/ParseHLSLRootSignatureTest.cpp - Add tests for some samples to ensure diagnostics are displayed correctly from HLSL input in
AST/HLSL/RootSignatures-AST.hlsl
Metadata
Metadata
Assignees
Labels
HLSLHLSL Language SupportHLSL Language Supportclang:frontendLanguage frontend issues, e.g. anything involving "Sema"Language frontend issues, e.g. anything involving "Sema"
Type
Projects
Status
Closed