[clang-tidy] `readability-implicit-bool-conversion` + `readability-uppercase-literal-suffix` should suggest uppercase literal suffix

[tearfur]

It'll be nice if readability-implicit-bool-conversion would suggest uppercase literal suffix when readability-uppercase-literal-suffix is also enabled. Currently it always suggests lowercase literal suffix.

https://godbolt.org/z/Wb9MaEj5M

<source>:6:10: warning: implicit conversion 'unsigned char' -> 'bool' [readability-implicit-bool-conversion]
    6 | bool b = uc();
      |          ^   
      |               != 0u

Current trunk: 1ff7491

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Yat Ho (tearfur)

It'll be nice if `readability-implicit-bool-conversion` would suggest uppercase literal suffix when `readability-uppercase-literal-suffix` is also enabled. Currently it always suggests lowercase literal suffix.

https://godbolt.org/z/Wb9MaEj5M

<source>:6:10: warning: implicit conversion 'unsigned char' -> 'bool' [readability-implicit-bool-conversion]
    6 | bool b = uc();
      |          ^   
      |               != 0u

Current trunk: 1ff7491

[carlosgalvezp]

I believe this has been discussed before. We have made an architectural decision that clang-tidy checks are independent from each other. Thus we don't want to implement logic that does different things depending on if other checks are enabled. Checks are not expected to be compatible with each other either.

The solution to this problem is to use the existing option UseUppercaseLiteralSuffix according to your needs.

[tearfur]

Thanks for the quick response.

That's understandable, I can imagine the code turning into a churning mess if options starts to affect each other.