[libc] Implement utimes

[michaelrj-google]

Described in Posix: https://pubs.opengroup.org/onlinepubs/9799919799/functions/futimens.html

Here's a checklist for what you'll need to do for this:

• Add the implementation of utimes in /src/sys/time (you will need to create this directory).
• Add tests for utimes in /test/src/sys/time (you will also need to create this directory).
  • Make sure the test has at least one case where the function succeeds and at least one case where the function fails.
• Add utimes to entrypoints.txt for at least x86_64 and whatever you're building on
• Add utims to include/sys/time.yaml

Comment if you're interested in working on this, and feel free to reach out if you need help.

[hoarfrost32]

hey @michaelrj-google , I would like to work on implementing this.

[michaelrj-google]

Assigned, thanks for picking this up!

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Michael Jones (michaelrj-google)

Described in Posix: https://pubs.opengroup.org/onlinepubs/9799919799/functions/futimens.html

Here's a checklist for what you'll need to do for this:

• Add the implementation of utimes in /src/sys/time (you will need to create this directory).
• Add tests for utimes in /test/src/sys/time (you will also need to create this directory).
  • Make sure the test has at least one case where the function succeeds and at least one case where the function fails.
• Add utimes to entrypoints.txt for at least x86_64 and whatever you're building on
• Add utims to include/sys/time.yaml

Comment if you're interested in working on this, and feel free to reach out if you need help.

[llvmbot]

@llvm/issue-subscribers-libc

Author: Michael Jones (michaelrj-google)

Described in Posix: https://pubs.opengroup.org/onlinepubs/9799919799/functions/futimens.html

Here's a checklist for what you'll need to do for this:

• Add the implementation of utimes in /src/sys/time (you will need to create this directory).
• Add tests for utimes in /test/src/sys/time (you will also need to create this directory).
  • Make sure the test has at least one case where the function succeeds and at least one case where the function fails.
• Add utimes to entrypoints.txt for at least x86_64 and whatever you're building on
• Add utims to include/sys/time.yaml

Comment if you're interested in working on this, and feel free to reach out if you need help.

[hoarfrost32]

hi @michaelrj-google, I've been working on this issue, and have implemented utimes as well as its tests. however, I could not test against the check-libc target, which kept failing due to an unrelated issue at the poll command. I did specifically test utimes against the tests I wrote and it is working.

Should I go ahead and open a PR?

[michaelrj-google]

Yes you should open a PR. If you're having that sort of build issue I'd recommend rerunning cmake. It could be that a folder got deleted and the test is failing to create a file.

[michaelrj-google]

Completed with #134167