[clang-format] Add 'cl' to enable OpenCL kernel file formatting

[wenju-he]

There are many .cl files in llvm repo. It would be great that clang-format can support it.

[llvmbot]

@llvm/pr-subscribers-clang-format

Author: Wenju He (wenju-he)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/134529.diff

1 Files Affected:

• (modified) clang/tools/clang-format/git-clang-format (+1)

diff --git a/clang/tools/clang-format/git-clang-format b/clang/tools/clang-format/git-clang-format
index 85eff4761e289..ba324b14ab80d 100755
--- a/clang/tools/clang-format/git-clang-format
+++ b/clang/tools/clang-format/git-clang-format
@@ -126,6 +126,7 @@ def main():
             "pb.txt",
             "textproto",
             "asciipb",  # TextProto
+            "cl", # OpenCL
         ]
     )
 

[mydeveloperday]

I feel like there are more places where this needs to be addressed if we are going to add it.

[mydeveloperday]

i.e. clang-format-diff.py

[mydeveloperday]

should we consider .ocl?

[wenju-he]

i.e. clang-format-diff.py

Thanks. I just find out that OpenCL support was already added in clang-format-diff.py by c49406d

[wenju-he]

I feel like there are more places where this needs to be addressed if we are going to add it.

I added support in language detection for OpenCL in 88c1174. It returns C language since OpenCL is based on C99 and C11 with restrictions, see https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html

[wenju-he]

should we consider .ocl?

.ocl isn't used as file extension for OpenCL. See

llvm-project/clang/lib/Frontend/FrontendOptions.cpp

Line 31 in a38ad6e

.Case("cl", Language::OpenCL)

[owenca]

I feel like there are more places where this needs to be addressed if we are going to add it.

I added support in language detection for OpenCL in 88c1174. It returns C language since OpenCL is based on C99 and C11 with restrictions, see https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html

OpenCL is formatted as C++ now. Do we really need to change that? See #132832 for potential problems.

[wenju-he]

I feel like there are more places where this needs to be addressed if we are going to add it.

I added support in language detection for OpenCL in 88c1174. It returns C language since OpenCL is based on C99 and C11 with restrictions, see https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html

OpenCL is formatted as C++ now. Do we really need to change that? See #132832 for potential problems.

reverted. Thanks. Default should be better if it works better.

[wenju-he]

@owenca could you please help me to merge? Thanks. I don't have commit permission.