CodeGen SPIR-V tests that specify --target-env vulkan1.3 are failing

[kmpeng]

When SPIRV-Tools is enabled, tests that specify the target environment vulkan1.3 in the validation step are failing. Specifically, the tests are:

• CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll (link)
• CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll (link)

This is happening because SPIRV-Tools seems to have grown some capability checks for 1.3. The target environments were originally added by suggestion in order to give more robust testing. #132288 (comment).

Proposed solution is to remove the --target-env specifications from these tests.

[kmpeng]

Tagging @s-perron for your thoughts on this and the proposed solution

[s-perron]

I won't be able to look in detail until Monday, but I would prefer to change the tests to not have external functions or variable. We could make the functions shader entry points.

The reason for using the vulkan environment is because some other restrictions are not checked by the validator, and they can be important.

[farzonl]

@s-perron the pipeline is still broken. I think this is just a solution to get the tests back to green. Alternatively we could mark these two XFAIL.

[s-perron]

Sure xfail, and leave an issue open to fix it.

[kmpeng]

Temporary fix: #136343
Issue tracking long-term fix: #136344