[lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) #137262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) ChangesFull diff: https://github.com/llvm/llvm-project/pull/137262.diff 1 Files Affected:
diff --git a/lldb/test/API/commands/process/reverse-continue/TestReverseContinueNotSupported.py b/lldb/test/API/commands/process/reverse-continue/TestReverseContinueCommandNotSupported.py
similarity index 100%
rename from lldb/test/API/commands/process/reverse-continue/TestReverseContinueNotSupported.py
rename to lldb/test/API/commands/process/reverse-continue/TestReverseContinueCommandNotSupported.py
|
Contributor
Author
|
cc @rocallahan (for some reason I can't add you as a reviewer) |
Contributor
|
Shouldn't you change the name of the Python class as well? |
Contributor
Author
|
I'll do that too (for what it's worth that name doesn't matter to the test system). |
JDevlieghere
approved these changes
Apr 25, 2025
DavidSpickett
approved these changes
Apr 25, 2025
Collaborator
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
Also noticed this trying to reproduce a failure on Windows with lldb-dotest.py, LGTM.
kastiglione
force-pushed
the
lldb-Rename-reverse-continue-TestReverseContinueNotSupported.py-NFC
branch
from
b37837e to
53b9bcc
Compare
kastiglione
deleted the
lldb-Rename-reverse-continue-TestReverseContinueNotSupported.py-NFC
branch
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…C) (llvm#137262) Rename this test because another test by the same name already exists: reverse-execution/TestReverseContinueNotSupported.py. Having multiple tests of the same name breaks running any test with: `lldb-dotest -p <TestName>`. This tests reverse continue _commands_, and so the rename adds "Commands" to the test name (TestReverseContinueCommandNotSupported.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename this test because another test by the same name already exists: reverse-execution/TestReverseContinueNotSupported.py.
Having multiple tests of the same name breaks running any test with:
lldb-dotest -p <TestName>.This tests reverse continue commands, and so the rename adds "Commands" to the test name (TestReverseContinueCommandNotSupported.py)