tools/dsymutil/X86/op-convert-offset.test randomly fails

[danilaml]

See discussion under #140227
Was bisected to change from #139907 by @peremyach

Pretty good reproducibility with ninja check-llvm-tools-dsymutil for Release build. Could reproduce for RelWithDebInfo.

[danilaml]

Here is the llvm-dwardump output with this change when built in release (that fails the test):

.debug_info contents:
0x00000000: Compile Unit: length = 0x00000023, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x00000027)

0x0000000c: DW_TAG_compile_unit
              DW_AT_producer	("clang version 15.0.0 (git@github.com:llvm/llvm-project.git 5edfc0b928b9ac4c653188828c5637de70bcf8ff)")
              DW_AT_language	(DW_LANG_C99)
              DW_AT_name	("op-convert-offset1.c")
              DW_AT_str_offsets_base	(0x00000008)
              DW_AT_stmt_list	(0x00000000)
              DW_AT_comp_dir	("/tmp/op-convert-offset")
              DW_AT_APPLE_optimized	(true)
              DW_AT_addr_base	(0x00000008)

0x0000001e:   DW_TAG_base_type
                DW_AT_name	("int")
                DW_AT_encoding	(DW_ATE_signed)
                DW_AT_byte_size	(0x04)

0x00000022:   DW_TAG_base_type
                DW_AT_name	("__ARRAY_SIZE_TYPE__")
                DW_AT_byte_size	(0x08)
                DW_AT_encoding	(DW_ATE_unsigned)

0x00000026:   NULL
0x00000027: Compile Unit: length = 0x00000058, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x002d, addr_size = 0x08 (next unit at 0x00000083)

0x00000033: DW_TAG_compile_unit
              DW_AT_producer	("clang version 15.0.0 (git@github.com:llvm/llvm-project.git 5edfc0b928b9ac4c653188828c5637de70bcf8ff)")
              DW_AT_language	(DW_LANG_C99)
              DW_AT_name	("op-convert-offset0.c")
              DW_AT_str_offsets_base	(0x0000002c)
              DW_AT_stmt_list	(0x00000046)
              DW_AT_comp_dir	("/tmp/op-convert-offset")
              DW_AT_APPLE_optimized	(true)
              DW_AT_low_pc	(0x0000000100003f90)
              DW_AT_high_pc	(0x0000000100003fa9)
              DW_AT_addr_base	(0x00000008)

0x0000004a:   DW_TAG_base_type
                DW_AT_name	("DW_ATE_unsigned_1")
                DW_AT_encoding	(DW_ATE_unsigned)
                DW_AT_byte_size	(0x01)

0x0000004e:   DW_TAG_base_type
                DW_AT_name	("DW_ATE_unsigned_8")
                DW_AT_encoding	(DW_ATE_unsigned)
                DW_AT_byte_size	(0x01)

0x00000052:   DW_TAG_subprogram
                DW_AT_low_pc	(0x0000000100003f90)
                DW_AT_high_pc	(0x0000000100003fa9)
                DW_AT_frame_base	(DW_OP_reg6 RBP)
                DW_AT_call_all_calls	(true)
                DW_AT_name	("foo")
                DW_AT_decl_file	("/tmp/op-convert-offset/op-convert-offset0.c")
                DW_AT_decl_line	(3)
                DW_AT_prototyped	(true)
                DW_AT_type	(0x000000000000001e "int")
                DW_AT_external	(true)
                DW_AT_APPLE_optimized	(true)

0x00000061:     DW_TAG_formal_parameter
                  DW_AT_location	(DW_OP_breg2 RCX+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0x0000004a) "DW_ATE_unsigned_1", DW_OP_convert (0x0000004e) "DW_ATE_unsigned_8", DW_OP_stack_value)
                  DW_AT_name	("b")
                  DW_AT_decl_file	("/tmp/op-convert-offset/op-convert-offset0.c")
                  DW_AT_decl_line	(3)
                  DW_AT_type	(0x0000007e "_Bool")

0x0000007d:     NULL

0x0000007e:   DW_TAG_base_type
                DW_AT_name	("_Bool")
                DW_AT_encoding	(DW_ATE_boolean)
                DW_AT_byte_size	(0x01)

0x00000082:   NULL

and when built with debug info (passes the test):

.debug_info contents:
0x00000000: Compile Unit: length = 0x0000005d, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x00000061)

0x0000000c: DW_TAG_compile_unit
              DW_AT_producer	("clang version 15.0.0 (git@github.com:llvm/llvm-project.git 5edfc0b928b9ac4c653188828c5637de70bcf8ff)")
              DW_AT_language	(DW_LANG_C99)
              DW_AT_name	("op-convert-offset1.c")
              DW_AT_str_offsets_base	(0x00000008)
              DW_AT_stmt_list	(0x00000000)
              DW_AT_comp_dir	("/tmp/op-convert-offset")
              DW_AT_APPLE_optimized	(true)
              DW_AT_low_pc	(0x0000000100003f80)
              DW_AT_high_pc	(0x0000000100003f8c)
              DW_AT_addr_base	(0x00000008)

0x00000023:   DW_TAG_variable
                DW_AT_name	("a")
                DW_AT_type	(0x00000035 "int[2]")
                DW_AT_external	(true)
                DW_AT_decl_file	("/tmp/op-convert-offset/op-convert-offset1.c")
                DW_AT_decl_line	(1)
                DW_AT_location	(DW_OP_addr 0x100004000)

0x00000035:   DW_TAG_array_type
                DW_AT_type	(0x00000041 "int")

0x0000003a:     DW_TAG_subrange_type
                  DW_AT_type	(0x00000045 "__ARRAY_SIZE_TYPE__")
                  DW_AT_count	(0x02)

0x00000040:     NULL

0x00000041:   DW_TAG_base_type
                DW_AT_name	("int")
                DW_AT_encoding	(DW_ATE_signed)
                DW_AT_byte_size	(0x04)

0x00000045:   DW_TAG_base_type
                DW_AT_name	("__ARRAY_SIZE_TYPE__")
                DW_AT_byte_size	(0x08)
                DW_AT_encoding	(DW_ATE_unsigned)

0x00000049:   DW_TAG_subprogram
                DW_AT_low_pc	(0x0000000100003f80)
                DW_AT_high_pc	(0x0000000100003f8c)
                DW_AT_frame_base	(DW_OP_reg6 RBP)
                DW_AT_call_all_calls	(true)
                DW_AT_name	("main")
                DW_AT_decl_file	("/tmp/op-convert-offset/op-convert-offset1.c")
                DW_AT_decl_line	(5)
                DW_AT_type	(0x00000041 "int")
                DW_AT_external	(true)
                DW_AT_APPLE_optimized	(true)

0x00000058:     DW_TAG_call_site
                  DW_AT_call_origin	(0x0000005f)
                  DW_AT_call_tail_call	(true)
                  DW_AT_call_pc	(0x0000000100003f87)

0x0000005e:     NULL

0x0000005f:   DW_TAG_subprogram

0x00000060:   NULL
0x00000061: Compile Unit: length = 0x00000058, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x007e, addr_size = 0x08 (next unit at 0x000000bd)

0x0000006d: DW_TAG_compile_unit
              DW_AT_producer	("clang version 15.0.0 (git@github.com:llvm/llvm-project.git 5edfc0b928b9ac4c653188828c5637de70bcf8ff)")
              DW_AT_language	(DW_LANG_C99)
              DW_AT_name	("op-convert-offset0.c")
              DW_AT_str_offsets_base	(0x0000002c)
              DW_AT_stmt_list	(0x0000005a)
              DW_AT_comp_dir	("/tmp/op-convert-offset")
              DW_AT_APPLE_optimized	(true)
              DW_AT_low_pc	(0x0000000100003f90)
              DW_AT_high_pc	(0x0000000100003fa9)
              DW_AT_addr_base	(0x00000020)

0x00000084:   DW_TAG_base_type
                DW_AT_name	("DW_ATE_unsigned_1")
                DW_AT_encoding	(DW_ATE_unsigned)
                DW_AT_byte_size	(0x01)

0x00000088:   DW_TAG_base_type
                DW_AT_name	("DW_ATE_unsigned_8")
                DW_AT_encoding	(DW_ATE_unsigned)
                DW_AT_byte_size	(0x01)

0x0000008c:   DW_TAG_subprogram
                DW_AT_low_pc	(0x0000000100003f90)
                DW_AT_high_pc	(0x0000000100003fa9)
                DW_AT_frame_base	(DW_OP_reg6 RBP)
                DW_AT_call_all_calls	(true)
                DW_AT_name	("foo")
                DW_AT_decl_file	("/tmp/op-convert-offset/op-convert-offset0.c")
                DW_AT_decl_line	(3)
                DW_AT_prototyped	(true)
                DW_AT_type	(0x0000000000000041 "int")
                DW_AT_external	(true)
                DW_AT_APPLE_optimized	(true)

0x0000009b:     DW_TAG_formal_parameter
                  DW_AT_location	(DW_OP_breg2 RCX+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0x00000084) "DW_ATE_unsigned_1", DW_OP_convert (0x00000088) "DW_ATE_unsigned_8", DW_OP_stack_value)
                  DW_AT_name	("b")
                  DW_AT_decl_file	("/tmp/op-convert-offset/op-convert-offset0.c")
                  DW_AT_decl_line	(3)
                  DW_AT_type	(0x000000b8 "_Bool")

0x000000b7:     NULL

0x000000b8:   DW_TAG_base_type
                DW_AT_name	("_Bool")
                DW_AT_encoding	(DW_ATE_boolean)
                DW_AT_byte_size	(0x01)

0x000000bc:   NULL

And the diff:

< 0x00000000: Compile Unit: length = 0x00000023, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x00000027)
---
> 0x00000000: Compile Unit: length = 0x0000005d, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x00000061)
13a14,15
>               DW_AT_low_pc    (0x0000000100003f80)
>               DW_AT_high_pc   (0x0000000100003f8c)
16c18,35
< 0x0000001e:   DW_TAG_base_type
---
> 0x00000023:   DW_TAG_variable
>                 DW_AT_name    ("a")
>                 DW_AT_type    (0x00000035 "int[2]")
>                 DW_AT_external        (true)
>                 DW_AT_decl_file       ("/tmp/op-convert-offset/op-convert-offset1.c")
>                 DW_AT_decl_line       (1)
>                 DW_AT_location        (DW_OP_addr 0x100004000)
> 
> 0x00000035:   DW_TAG_array_type
>                 DW_AT_type    (0x00000041 "int")
> 
> 0x0000003a:     DW_TAG_subrange_type
>                   DW_AT_type  (0x00000045 "__ARRAY_SIZE_TYPE__")
>                   DW_AT_count (0x02)
> 
> 0x00000040:     NULL
> 
> 0x00000041:   DW_TAG_base_type
21c40
< 0x00000022:   DW_TAG_base_type
---
> 0x00000045:   DW_TAG_base_type
26,27c45,62
< 0x00000026:   NULL
< 0x00000027: Compile Unit: length = 0x00000058, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x002d, addr_size = 0x08 (next unit at 0x00000083)
---
> 0x00000049:   DW_TAG_subprogram
>                 DW_AT_low_pc  (0x0000000100003f80)
>                 DW_AT_high_pc (0x0000000100003f8c)
>                 DW_AT_frame_base      (DW_OP_reg6 RBP)
>                 DW_AT_call_all_calls  (true)
>                 DW_AT_name    ("main")
>                 DW_AT_decl_file       ("/tmp/op-convert-offset/op-convert-offset1.c")
>                 DW_AT_decl_line       (5)
>                 DW_AT_type    (0x00000041 "int")
>                 DW_AT_external        (true)
>                 DW_AT_APPLE_optimized (true)
> 
> 0x00000058:     DW_TAG_call_site
>                   DW_AT_call_origin   (0x0000005f)
>                   DW_AT_call_tail_call        (true)
>                   DW_AT_call_pc       (0x0000000100003f87)
> 
> 0x0000005e:     NULL
29c64,69
< 0x00000033: DW_TAG_compile_unit
---
> 0x0000005f:   DW_TAG_subprogram
> 
> 0x00000060:   NULL
> 0x00000061: Compile Unit: length = 0x00000058, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x007e, addr_size = 0x08 (next unit at 0x000000bd)
> 
> 0x0000006d: DW_TAG_compile_unit
34c74
<               DW_AT_stmt_list (0x00000046)
---
>               DW_AT_stmt_list (0x0000005a)
39c79
<               DW_AT_addr_base (0x00000008)
---
>               DW_AT_addr_base (0x00000020)
41c81
< 0x0000004a:   DW_TAG_base_type
---
> 0x00000084:   DW_TAG_base_type
46c86
< 0x0000004e:   DW_TAG_base_type
---
> 0x00000088:   DW_TAG_base_type
51c91
< 0x00000052:   DW_TAG_subprogram
---
> 0x0000008c:   DW_TAG_subprogram
60c100
<                 DW_AT_type    (0x000000000000001e "int")
---
>                 DW_AT_type    (0x0000000000000041 "int")
64,65c104,105
< 0x00000061:     DW_TAG_formal_parameter
<                   DW_AT_location      (DW_OP_breg2 RCX+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0x0000004a) "DW_ATE_unsigned_1", DW_OP_convert (0x0000004e) "DW_ATE_unsigned_8", DW_OP_stack_value)
---
> 0x0000009b:     DW_TAG_formal_parameter
>                   DW_AT_location      (DW_OP_breg2 RCX+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0x00000084) "DW_ATE_unsigned_1", DW_OP_convert (0x00000088) "DW_ATE_unsigned_8", DW_OP_stack_value)
69c109
<                   DW_AT_type  (0x0000007e "_Bool")
---
>                   DW_AT_type  (0x000000b8 "_Bool")
71c111
< 0x0000007d:     NULL
---
> 0x000000b7:     NULL
73c113
< 0x0000007e:   DW_TAG_base_type
---
> 0x000000b8:   DW_TAG_base_type
78c118
< 0x00000082:   NULL
---
> 0x000000bc:   NULL

Looks like DW_TAG_variable and DW_TAG_subprogram parts are missing from the "bad" output.

[peremyach]

Looking into it

[ilovepi]

FWIW, we're also seeing this in Fuchsia's toolchain builds https://ci.chromium.org/ui/p/fuchsia/builders/prod/clang-host-linux-x64/b8714409990339056513/overview

[ilovepi]

@peremyach if there isn't too much dependent work landed since your patch, I wonder if you'd rather just revert for now and reupload once you have a fixed version ready?

[alanzhao1]

Chrome is also seeing this issue: https://crbug.com/418266940

[dyung]

What I've done downstream to temporarily work around this issue is to mark the test as UNSUPPORTED if asserts are not present with # UNSUPPORTED: !asserts

[ilovepi]

What I've done downstream to temporarily work around this issue is to mark the test as UNSUPPORTED if asserts are not present with # UNSUPPORTED: !asserts

Fuchsia does not cary any downstream patches to the toolchain, so that's a bit challenging.