[clang-doc] Avoid reading files in unit tests

[ilovepi]

In #138062 it was brought up that this was an anti-pattern. We'll need
to Migrate all of the mustache unittests that need to read template
files to lit tests, and disable them until tool support lands.

[ilovepi]

• [clang-doc] Avoid reading files in unit tests #141269 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

Author: Paul Kirth (ilovepi)

Changes

In #138062 it was brought up that this was an anti-pattern. We'll need
to Migrate all of the mustache unittests to lit tests, and disable them
until tool support lands.

---

Full diff: https://github.com/llvm/llvm-project/pull/141269.diff

1 Files Affected:

• (modified) clang-tools-extra/unittests/clang-doc/HTMLMustacheGeneratorTest.cpp (+4-2)

diff --git a/clang-tools-extra/unittests/clang-doc/HTMLMustacheGeneratorTest.cpp b/clang-tools-extra/unittests/clang-doc/HTMLMustacheGeneratorTest.cpp
index 70491f0754b3d..4c8cf4fa7e460 100644
--- a/clang-tools-extra/unittests/clang-doc/HTMLMustacheGeneratorTest.cpp
+++ b/clang-tools-extra/unittests/clang-doc/HTMLMustacheGeneratorTest.cpp
@@ -91,10 +91,12 @@ TEST(HTMLMustacheGeneratorTest, generateDocs) {
   unittest::TempDir RootTestDirectory("generateDocsTest", /*Unique=*/true);
   CDCtx.OutDirectory = RootTestDirectory.path();
 
-  getMustacheHtmlFiles(CLANG_DOC_TEST_ASSET_DIR, CDCtx);
+  // FIXME: We can't read files during unit tests. Migrate to lit once
+  // tool support lands.
+  // getMustacheHtmlFiles(CLANG_DOC_TEST_ASSET_DIR, CDCtx);
 
   EXPECT_THAT_ERROR(G->generateDocs(RootTestDirectory.path(), {}, CDCtx),
-                    Succeeded())
+                    Failed())
       << "Failed to generate docs.";
 }
 

[ilovepi]

Merge activity

• May 23, 6:45 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 23, 6:47 PM UTC: @ilovepi merged this pull request with Graphite.

[nico]

Thanks! Can we stop generating config.h from config.h.cmake again too? That should no longer be needed now.