[clangd] In the body of a function with an explicit object parameter, code completion suggests members without accessing them through the object parameter

[olemayu]

None of the clangd display hints and auto-completions work with deduced this.

Example: CurrentValue suggested even though it cant be used without Self.

Member function calls display the overlay with Self, thus shoving the actual relevant arguments that are being filled.

Example: Self shown even though the Value is the one being filled.

tested on clangd version: 21.0.0

[llvmbot]

@llvm/issue-subscribers-clangd

Author: None (olemayu)

None of the clangd display hints and auto-completions work with **deduced this**.

Example: CurrentValue suggested even though it cant be used without Self.

Member function calls display the overlay with Self, thus shoving the actual relevant arguments that are being filled.

Example: Self shown even though the Value is the one being filled.

tested on clangd version: 21.0.0

[HighCommander4]

We have clangd/clangd#2284 on file for the second issue. We can use this ticket to track the first issue.

[MythreyaK]

I'm having a hard time reproducing this, could you share the clangd version, the config in vscode and any CLI args you're passing in?

[HighCommander4]

I'm having a hard time reproducing this, could you share the clangd version, the config in vscode and any CLI args you're passing in?

FWIW, I wrote a unit test for this which is failing in the expected way on latest trunk.

[MythreyaK]

FWIW, I wrote a unit test for this which is failing in the expected way on latest trunk.

Sweet, thank you!

[MythreyaK]

Instead of not offering any code complete for mem^, would suggesting self.member as the insertion be better in terms of user experience?

[olemayu]

Instead of not offering any code complete for mem^, would suggesting self.member as the insertion be better in terms of user experience?

That would fit the clangd config option Completion.AllScopes quite nicely I think. I keep that off so that's why I bring this up. I would personally not want the suggestions.

[HighCommander4]

Instead of not offering any code complete for mem^, would suggesting self.member as the insertion be better in terms of user experience?

I think that could be a nice future enhancement to consider. As a short-term fix though, I think just not offering the incorrect completion is fine; the user can always type self.^ to get completion for class members.