Skip to content

Conversation

@DavidSpickett
Copy link
Collaborator

Instead of distutils.LooseVersion. distutils was depracated (https://peps.python.org/pep-0632/) and has been removed in Python 3.12 (https://docs.python.org/3/whatsnew/3.12.html)

Of note, the distutils package has been removed from the standard library.

packaging's version is able to handle glibc's major.minor: https://packaging.pypa.io/en/latest/version.html#packaging.version.Version

For these modules or types, use the standards-defined Python Packaging Authority packages specified:
distutils.version — use the packaging package

Relates to #54337

…rsions

Instead of distutils.LooseVersion. distutils was depracated
(https://peps.python.org/pep-0632/) and has been removed in
Python 3.12 (https://docs.python.org/3/whatsnew/3.12.html)

> Of note, the distutils package has been removed from the standard library.

packaging's version is able to handle glibc's major.minor:
https://packaging.pypa.io/en/latest/version.html#packaging.version.Version

> For these modules or types, use the standards-defined Python Packaging Authority packages specified:
> distutils.version — use the packaging package

Relates to llvm#54337
@DavidSpickett
Copy link
Collaborator Author

Might require packaging to be installed on some buildbots. Linaro gets it from the python3-packaging apt package. I will go through zorg and make a list of bots that might be effected.

@DavidSpickett
Copy link
Collaborator Author

I will go through zorg and make a list of bots that might be effected.

On second thought, this is going to take me an age. So I suggest reviewers take a look first, and then I will contact bot owners.

@DavidSpickett
Copy link
Collaborator Author

@DavidSpickett DavidSpickett merged commit f56309a into llvm:main Sep 11, 2025
12 checks passed
@DavidSpickett DavidSpickett deleted the compiler-rt-glibc branch September 11, 2025 08:33
@aeubanks
Copy link
Contributor

this seems to have caused a couple of tests that have checks for the glibc version to start failing on our bots and I'm not sure why: https://g-issues.chromium.org/issues/444460536. still investigating

@aeubanks
Copy link
Contributor

I have a random theory that the new package is bailing on "invalid" versions like . or 2. when the old package wasn't

DavidSpickett added a commit that referenced this pull request Sep 12, 2025
…glibc versions" (#158230)

Reverts #142596

Got reports that some tests previously skipped are running again and
failing.
@DavidSpickett
Copy link
Collaborator Author

I've reverted this. Will try out invalid versions with both and see what happens. Should be able to emulate the old behaviour.

llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Sep 12, 2025
…to compare glibc versions" (#158230)

Reverts llvm/llvm-project#142596

Got reports that some tests previously skipped are running again and
failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants