-
Couldn't load subscription status.
- Fork 15k
[compiler-rt][test] Use packaging.version.Version to compare glibc versions #142596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rsions Instead of distutils.LooseVersion. distutils was depracated (https://peps.python.org/pep-0632/) and has been removed in Python 3.12 (https://docs.python.org/3/whatsnew/3.12.html) > Of note, the distutils package has been removed from the standard library. packaging's version is able to handle glibc's major.minor: https://packaging.pypa.io/en/latest/version.html#packaging.version.Version > For these modules or types, use the standards-defined Python Packaging Authority packages specified: > distutils.version — use the packaging package Relates to llvm#54337
|
Might require |
On second thought, this is going to take me an age. So I suggest reviewers take a look first, and then I will contact bot owners. |
|
Posted https://discourse.llvm.org/t/psa-compiler-rt-linux-buildbots-will-in-future-require-the-python-packaging-module/88100 and emailed all the known buildbot admins today. |
|
this seems to have caused a couple of tests that have checks for the glibc version to start failing on our bots and I'm not sure why: https://g-issues.chromium.org/issues/444460536. still investigating |
|
I have a random theory that the new package is bailing on "invalid" versions like |
|
I've reverted this. Will try out invalid versions with both and see what happens. Should be able to emulate the old behaviour. |
…to compare glibc versions" (#158230) Reverts llvm/llvm-project#142596 Got reports that some tests previously skipped are running again and failing.
Instead of distutils.LooseVersion. distutils was depracated (https://peps.python.org/pep-0632/) and has been removed in Python 3.12 (https://docs.python.org/3/whatsnew/3.12.html)
packaging's version is able to handle glibc's major.minor: https://packaging.pypa.io/en/latest/version.html#packaging.version.Version
Relates to #54337