[libc][cmake] Make libc not included in LLVM_ENABLE_PROJECTS=all. #142626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
reviewed
Jun 3, 2025
Contributor
jhuber6
left a comment
jhuber6
left a comment
There was a problem hiding this comment.
I don't think it's proper to add it to extra projects, those are supposed to be 'experimental' I believe. Either way, this list confuses me. I'm guessing it's just a list of all known subdirectories? If so then where's libcxx?
Contributor
Author
It looks like |
Collaborator
|
A few lines later, we have "Using LLVM_ENABLE_PROJECTS=libc is deprecated now, and will become a fatal error in the LLVM 21 release." If we're going to make it a fatal error for 21, we should probably do that soon... if not, we should update the text with an updated timeline. |
petrhosek
reviewed
Jun 4, 2025
llvm/CMakeLists.txt
Outdated
| list(REMOVE_ITEM LLVM_ALL_PROJECTS openmp) | ||
| endif() | ||
|
|
||
| # The flang project is not yet part of "all" projects (see C++ requirements) |
Member
There was a problem hiding this comment.
This comments probably needs to be updated.
petrhosek
approved these changes
Jun 4, 2025
Contributor
Author
Done. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/85/builds/9530 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make LLVM libc to not be included in
LLVM_ENABLE_PROJECTS=all. It can still be manually added to LLVM_ENABLE_PROJECTS list.