[clang-move] Teach getDeclarationList to return ArrayRef (NFC) #143278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getDeclarationList is used only for read-only access to the array. I don't think it's actually meant to return by value.
Member
|
@llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) ChangesgetDeclarationList is used only for read-only access to the array. I Full diff: https://github.com/llvm/llvm-project/pull/143278.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-move/Move.h b/clang-tools-extra/clang-move/Move.h
index ea241bbbc4f8a..ba613abc03e19 100644
--- a/clang-tools-extra/clang-move/Move.h
+++ b/clang-tools-extra/clang-move/Move.h
@@ -49,9 +49,7 @@ class DeclarationReporter {
bool Templated = false; // Whether the declaration is templated.
};
- const std::vector<Declaration> getDeclarationList() const {
- return DeclarationList;
- }
+ ArrayRef<Declaration> getDeclarationList() const { return DeclarationList; }
private:
std::vector<Declaration> DeclarationList;
|
shiltian
approved these changes
Jun 7, 2025
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…143278) getDeclarationList is used only for read-only access to the array. I don't think it's actually meant to return by value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDeclarationList is used only for read-only access to the array. I
don't think it's actually meant to return by value.