Remove PSTL from the top-level monorepo #143717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFC for this removal can be found at: https://discourse.llvm.org/t/rfc-removing-pstl/86807 Note, libc++ still supports PSTL. That support is integrated directly into the libc++ source tree. There is no release note for this removal because it's not really clear that this was user-facing facilities or where such a release note should live.
Collaborator
Author
|
Posting the PR to see how well precommit CI likes the changes while the RFC is still under discussion. |
DrSergei
pushed a commit
to DrSergei/llvm-project
that referenced
this pull request
Jun 24, 2025
The RFC for this removal can be found at: https://discourse.llvm.org/t/rfc-removing-pstl/86807 Note, libc++ still supports PSTL. That support is integrated directly into the libc++ source tree. There is no release note for this removal because it's not really clear that this was user-facing facilities or where such a release note should live.
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/12044 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/35793 Here is the relevant piece of the build log for the reference |
Collaborator
|
You broke the bots here: do you have a fix on-going? @AaronBallman |
Collaborator
Author
Ah, I lost this in the firehose of emails -- thank you for the ping! The first bot is not failing due to these changes: but the second bot seems to have a configuration issue: I'll see if I can figure out where that config lives and deal with it. |
Collaborator
Author
|
I've put up llvm/llvm-zorg#485 which hopefully resolves the issue |
Collaborator
|
I'm concerned this requires a master buildbot restart, if you don't manage to get @gkistanova acknowledge this quickly we need to revert or land another fix in the monorepo in the meantime. |
Collaborator
Author
We can certainly revert (the churn would be unfortunate though). I'm not certain what other fix would be possible if a restart is required. I've raised the point on the |
Collaborator
|
A trivial fix is to accept the pstl in cmake and ignore it. |
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
The RFC for this removal can be found at: https://discourse.llvm.org/t/rfc-removing-pstl/86807 Note, libc++ still supports PSTL. That support is integrated directly into the libc++ source tree. There is no release note for this removal because it's not really clear that this was user-facing facilities or where such a release note should live.
Collaborator
|
Ping? |
joker-eph
added a commit
that referenced
this pull request
Jun 26, 2025
This reverts commit f8ed456.
Collaborator
Author
For some reason the builder still isn't rebooted. IMO, this is a pretty serious gap with our infrastructure handling; we need more folks with permissions to help out in these kinds of situations.
I don't know CMake well enough to know how to make that work; if you know of the magic incantation to do it, I'm happy to review it so we can land it ASAP. (I'd still like to avoid a revert because of the amount of churn for something that's already fixed.) |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/6711 Here is the relevant piece of the build log for the reference |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC for this removal can be found at:
https://discourse.llvm.org/t/rfc-removing-pstl/86807
Note, libc++ still supports PSTL. That support is integrated directly into the libc++ source tree.
There is no release note for this removal because it's not really clear that this was user-facing facilities or where such a release note should live.