CodeGenFunction take LValue by value in many of its member function

[shafik]

Static analysis has pointed out that LValue is not a small object but in several member functions of CodeGenFunction it passes around an LValue by value when it could take it by const &.

I don't see a good reason to not refactor but perhaps I am missing something.

[shafik]

CC @AaronBallman @cor3ntin

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Shafik Yaghmour (shafik)

Static analysis has pointed out that `LValue` is not a small object but in several member functions of `CodeGenFunction` it passes around an `LValue` by value when it could take it by const &.

I don't see a good reason to not refactor but perhaps I am missing something.

[llvmbot]

@llvm/issue-subscribers-clang-codegen

Author: Shafik Yaghmour (shafik)

Static analysis has pointed out that `LValue` is not a small object but in several member functions of `CodeGenFunction` it passes around an `LValue` by value when it could take it by const &.

I don't see a good reason to not refactor but perhaps I am missing something.

[AaronBallman]

CC @efriedma-quic @rjmccall in case they see a reason not to go this route

[efriedma-quic]

It's fine. I mean, it's not so big that it's a huge difference either way, but sure.

[rjmccall]

Yeah, I have no problem with passing it around by const &.