[llvm] remove incorrect LLVM_ABI annotation usage

[andrurogerz]

Overview

This patch removes incorrect usage of LLVM_ABI macros that break the (currently incomplete) LLVM Windows DLL build.

• ec71d80 added LLVM_ABI to template methods fully declared in a header file
• 254a92d added LLVM_ABI to members of a class already annotated with LLVM_ABI

Background

Documentation for LLVM_ABI and related annotations is found in the LLVM repo here.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[andrurogerz]

@compnerd, @vgvassilev here's the first PR I've had to make to fix mistaken LLVM_ABI annotations by others. I think we will need to update to ids so that it catches this sort of mistake. Right now, ids focuses on on where annotations are missing, but to fully prevent Windows DLL build breaks, it will also need to flag annotations that are unnecessary or in the wrong place.

[vgvassilev]

@compnerd, @vgvassilev here's the first PR I've had to make to fix mistaken LLVM_ABI annotations by others. I think we will need to update to ids so that it catches this sort of mistake. Right now, ids focuses on on where annotations are missing, but to fully prevent Windows DLL build breaks, it will also need to flag annotations that are unnecessary or in the wrong place.

That’s a good point and probably a good time for the ci work to start. Can you find us on discord — we have a few questions for you outside of this pr ;)

[vgvassilev]

LGTM!