CGHLSLRuntime::initializeBufferFromBinding unconditionally dereferencing RBA after a nullptr check

[shafik]

On this line we have a nullptr check on RBA:

llvm-project/clang/lib/CodeGen/CGHLSLRuntime.cpp

Lines 592 to 593 in 12ba751

	auto *Space =
	llvm::ConstantInt::get(CGM.IntTy, RBA ? RBA->getSpaceNumber() : 0);

but soon after we unconditionally dereference RBA:

llvm-project/clang/lib/CodeGen/CGHLSLRuntime.cpp

Lines 596 to 600 in 12ba751

	llvm::Intrinsic::ID IntrinsicID =
	RBA->hasRegisterSlot()
	? CGM.getHLSLRuntime().getCreateHandleFromBindingIntrinsic()
	: CGM.getHLSLRuntime().getCreateHandleFromImplicitBindingIntrinsic();

So one of these lines is a bug, I am not sure which it is.

This change was brought in by: #139022

[shafik]

CC @hekota @bogner

[llvmbot]

@llvm/issue-subscribers-clang-codegen

Author: Shafik Yaghmour (shafik)

On this line we have a `nullptr` check on `RBA`:

llvm-project/clang/lib/CodeGen/CGHLSLRuntime.cpp

Lines 592 to 593 in 12ba751

	auto *Space =
	llvm::ConstantInt::get(CGM.IntTy, RBA ? RBA->getSpaceNumber() : 0);

but soon after we unconditionally dereference RBA:

llvm-project/clang/lib/CodeGen/CGHLSLRuntime.cpp

Lines 596 to 600 in 12ba751

	llvm::Intrinsic::ID IntrinsicID =
	RBA->hasRegisterSlot()
	? CGM.getHLSLRuntime().getCreateHandleFromBindingIntrinsic()
	: CGM.getHLSLRuntime().getCreateHandleFromImplicitBindingIntrinsic();

So one of these lines is a bug, I am not sure which it is.

This change was brought in by: #139022