Skip to content

Conversation

topolarity
Copy link

This environment variable is set by perf record -e intel_pt to indicate that an arch-specific timestamp should be used when emitting the jitdump instead of CLOCK_MONOTONIC, which allows the dump to be correlated to the Intel PT recording data by perf inject --jit.

Without this change perf inject complains that the recording was taken improperly:

$ perf inject --jit --input perf.data --output perf.jit.data                  
error, jitted code must be sampled with perf record -k 1

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@topolarity topolarity changed the title [JIT] Respect JITDUMP_USE_ARCH_TIMESTAMP environment variable [JIT][X86] Respect JITDUMP_USE_ARCH_TIMESTAMP environment variable Jun 27, 2025
@gbaraldi
Copy link
Contributor

Do you not need to change anything in JITLoaderPerf?

This environment variable is set by `perf record -e intel_pt` to indicate that an
arch-specific timestamp should be used when emitting the jitdump instead of
CLOCK_MONOTONIC, which allows the dump to be correlated to the Intel PT recording
data by `perf inject --jit`.
@topolarity topolarity force-pushed the use-arch-timestamp branch from 62e0f16 to b83f2db Compare June 27, 2025 16:53
@topolarity
Copy link
Author

topolarity commented Jun 27, 2025

Do you not need to change anything in JITLoaderPerf?

Thanks! I didn't notice there was another implementation that needed updating.

@topolarity topolarity changed the title [JIT][X86] Respect JITDUMP_USE_ARCH_TIMESTAMP environment variable [ORC][X86] Respect JITDUMP_USE_ARCH_TIMESTAMP environment variable Jun 29, 2025
@topolarity
Copy link
Author

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants