-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[mlir][tblgen] Fix test definition names to reflect expected valid results (NFC) #146243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir Author: Henrich Lauko (xlauko) ChangesFull diff: https://github.com/llvm/llvm-project/pull/146243.diff 1 Files Affected:
diff --git a/mlir/test/mlir-tblgen/op-format-spec.td b/mlir/test/mlir-tblgen/op-format-spec.td
index 03b63f42c7767..1541cd09f53e0 100644
--- a/mlir/test/mlir-tblgen/op-format-spec.td
+++ b/mlir/test/mlir-tblgen/op-format-spec.td
@@ -95,7 +95,7 @@ def DirectiveRegionsValid : TestFormat_Op<[{
//===----------------------------------------------------------------------===//
// CHECK-NOT: error:
-def DirectiveResultsInvalidA : TestFormat_Op<[{
+def DirectiveResultsValid : TestFormat_Op<[{
type(results) attr-dict
}]>;
@@ -104,7 +104,7 @@ def DirectiveResultsInvalidA : TestFormat_Op<[{
//===----------------------------------------------------------------------===//
// CHECK-NOT: error:
-def DirectiveSuccessorsInvalidA : TestFormat_Op<[{
+def DirectiveSuccessorsValid : TestFormat_Op<[{
successors attr-dict
}]>;
@@ -167,7 +167,7 @@ def OptionalValidA : TestFormat_Op<[{
//===----------------------------------------------------------------------===//
// CHECK-NOT: error
-def StringInvalidA : TestFormat_Op<[{ custom<Foo>("foo") attr-dict }]>;
+def StringValid : TestFormat_Op<[{ custom<Foo>("foo") attr-dict }]>;
//===----------------------------------------------------------------------===//
// Variables
|
bc29f7f to
e2ad5d5
Compare
9719d94 to
43e2282
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
zero9178
approved these changes
Jun 30, 2025
Member
zero9178
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
43e2282 to
8923501
Compare
e2ad5d5 to
36536e8
Compare
8923501 to
a574831
Compare
24941e8 to
e0c10a2
Compare
a574831 to
350e6d4
Compare
Contributor
Author
Merge activity
|
350e6d4 to
2701a0a
Compare
Base automatically changed from
users/xlauko/mlir-tblgen-region-ref-parser
to
main
July 1, 2025 10:30
e0c10a2 to
9bfcc35
Compare
9bfcc35 to
8fe912a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

No description provided.