Allow scalar int8 tensors to be unranked in the TOSA dialect

[lhutton1]

Scalar operands in the TOSA dialect are currently required to be ranked. This leads to issues/reports similar to the following: https://discourse.llvm.org/t/tosa-pad-operand-must-be-tosa-conformant-scalar-tensor-of-number-values/87432

Scalar tensors are defined with the tablegen definition Tosa_ScalarInt8Tensor. This issue would require updating this definition to allow a scalar tensor to either be ranked or unranked. A similar pull request for reference can be found here: #143770 or here: #150399. Tests should also be added to support the change.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Luke Hutton (lhutton1)

Scalar operands in the TOSA dialect are currently required to be ranked. This leads to issues/reports similar to the following: https://discourse.llvm.org/t/tosa-pad-operand-must-be-tosa-conformant-scalar-tensor-of-number-values/87432

Scalar tensors are defined with the tablegen definition Tosa_ScalarInt8Tensor. This issue would require updating this definition to allow a scalar tensor to either be ranked or unranked. A similar pull request for reference can be found here: #143770 or here: #150399. Tests should also be added to support the change.

[yichi170]

@lhutton1 I would like to work on this. This will be my first time working with MLIR, so I’d appreciate any feedback or guidance you can offer! Thanks!

[lhutton1]

Thanks @yichi170, happy to help! I'll assign this issue to you