[MLIR] Remove uses of %T from lit tests #150725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
%T has been deprecated for about seven years and is to be avoided given it does not use a unique dir per test. Remove it from lit tests in MLIR with the eventual goal to be removing support within llvm-lit. This patch just reuses %t.o given it is deleted in between sections of the test.
Member
|
@llvm/pr-subscribers-mlir Author: Aiden Grossman (boomanaiden154) Changes%T has been deprecated for about seven years and is to be avoided given it does not use a unique dir per test. Remove it from lit tests in MLIR with the eventual goal to be removing support within llvm-lit. This patch just reuses %t.o given it is deleted in between sections of the test. Full diff: https://github.com/llvm/llvm-project/pull/150725.diff 1 Files Affected:
diff --git a/mlir/test/mlir-runner/simple.mlir b/mlir/test/mlir-runner/simple.mlir
index 1a03b9901174f..21dabdd42825e 100644
--- a/mlir/test/mlir-runner/simple.mlir
+++ b/mlir/test/mlir-runner/simple.mlir
@@ -15,10 +15,10 @@
// RUN: ls %t.o
// RUN: rm %t.o
-// RUN: mlir-runner %s -dump-object-file -object-filename=%T/test.o \
+// RUN: mlir-runner %s -dump-object-file -object-filename=%t.o \
// RUN: %if target={{s390x-.*}} %{ -argext-abi-check=false %} | FileCheck %s
-// RUN: ls %T/test.o
-// RUN: rm %T/test.o
+// RUN: ls %t.o
+// RUN: rm %t.o
// Declarations of C library functions.
llvm.func @logbf(f32) -> f32
|
joker-eph
approved these changes
Jul 26, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
%T has been deprecated for about seven years and is to be avoided given it does not use a unique dir per test. Remove it from lit tests in MLIR with the eventual goal to be removing support within llvm-lit. This patch just reuses %t.o given it is deleted in between sections of the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%T has been deprecated for about seven years and is to be avoided given it does not use a unique dir per test. Remove it from lit tests in MLIR with the eventual goal to be removing support within llvm-lit.
This patch just reuses %t.o given it is deleted in between sections of the test.