[Flang] English error in compilation error message

[ohno-fj]

Version of flang : 22.0.0(e3af202fd212a66700170717856a8fa9aa7ed426)/AArch64

In the attached program, the article a written between is and not in the compilation error message seems unnecessary.

The following is an excerpt of the message.

error: pointer 'i04_pn01' is associated with the result of a reference to function 'merge' that is a not a pointer
　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　 ^

The following are the test program, Flang compilation result.

snfg_mktest_216_2.f90:

program main
  intrinsic :: merge
  integer(kind = 4), pointer     :: i04_pn01(:)
  i04_pn01 => merge(i04_pn01,i04_pn01,.true.)
end program main

$ flang snfg_mktest_216_2.f90
error: Semantic errors in snfg_mktest_216_2.f90
./snfg_mktest_216_2.f90:4:3: error: pointer 'i04_pn01' is associated with the result of a reference to function 'merge' that is a not a pointer
    i04_pn01 => merge(i04_pn01,i04_pn01,.true.)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
./snfg_mktest_216_2.f90:3:37: Declaration of pointer 'i04_pn01'
    integer(kind = 4), pointer     :: i04_pn01(:)
                                      ^^^^^^^^
$

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: None (ohno-fj)

``` Version of flang : 22.0.0(e3af202)/AArch64 ```

In the attached program, the article a written between is and not in the compilation error message seems unnecessary.

The following is an excerpt of the message.

error: pointer 'i04_pn01' is associated with the result of a reference to function 'merge' that is a not a pointer
　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　 ^

The following are the test program, Flang compilation result.

snfg_mktest_216_2.f90:

program main
  intrinsic :: merge
  integer(kind = 4), pointer     :: i04_pn01(:)
  i04_pn01 => merge(i04_pn01,i04_pn01,.true.)
end program main

$ flang snfg_mktest_216_2.f90
error: Semantic errors in snfg_mktest_216_2.f90
./snfg_mktest_216_2.f90:4:3: error: pointer 'i04_pn01' is associated with the result of a reference to function 'merge' that is a not a pointer
    i04_pn01 => merge(i04_pn01,i04_pn01,.true.)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
./snfg_mktest_216_2.f90:3:37: Declaration of pointer 'i04_pn01'
    integer(kind = 4), pointer     :: i04_pn01(:)
                                      ^^^^^^^^
$

[llvmbot]

@llvm/issue-subscribers-flang-frontend

Author: None (ohno-fj)

``` Version of flang : 22.0.0(e3af202)/AArch64 ```

In the attached program, the article a written between is and not in the compilation error message seems unnecessary.

The following is an excerpt of the message.

error: pointer 'i04_pn01' is associated with the result of a reference to function 'merge' that is a not a pointer
　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　　 ^

The following are the test program, Flang compilation result.

snfg_mktest_216_2.f90:

program main
  intrinsic :: merge
  integer(kind = 4), pointer     :: i04_pn01(:)
  i04_pn01 => merge(i04_pn01,i04_pn01,.true.)
end program main

$ flang snfg_mktest_216_2.f90
error: Semantic errors in snfg_mktest_216_2.f90
./snfg_mktest_216_2.f90:4:3: error: pointer 'i04_pn01' is associated with the result of a reference to function 'merge' that is a not a pointer
    i04_pn01 => merge(i04_pn01,i04_pn01,.true.)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
./snfg_mktest_216_2.f90:3:37: Declaration of pointer 'i04_pn01'
    integer(kind = 4), pointer     :: i04_pn01(:)
                                      ^^^^^^^^
$

[Sekar-C-Mca]

@ohno-fj
Hi, I'd like to take it and submit a pull request once the fix is ready.

[Sekar-C-Mca]

@ohno-fj fixed pr #150909

[ohno-fj]

@Sekar-C-Mca
@klausler
Thank you for your comment.
I appreciate your fix.