Skip to content

Conversation

daltenty
Copy link
Member

On AIX we prefer to create shared libraries as shared library archives (i.e. we archive the shared object in a big AR archive) as this is the standard format on the platform.

There is now a CMake policy that allows us to do this by default, so opt-in to that behaviour.

On AIX we prefer to create shared libraries as shared library archives (i.e. we archive the shared object in a big AR archive) as this is the standard format on the platform.

There is now a CMake policy that allows us to do this by default, so opt-in to that behaviour.
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Aug 27, 2025
Copy link
Collaborator

@hubert-reinterpretcast hubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nit.

Co-authored-by: Hubert Tong <[email protected]>
@daltenty daltenty merged commit 94738dd into llvm:main Aug 28, 2025
69 of 73 checks passed
@daltenty daltenty deleted the daltenty/cmake-policy-cmp0182 branch August 28, 2025 13:29
t-a-james pushed a commit to t-a-james/llvm-project that referenced this pull request Aug 28, 2025
…oject into bugprone-method-hiding

* 'bugprone-method-hiding' of github.com:t-a-james/llvm-project: (230 commits)
  [SimplifyCFG] Move token type check into canReplaceOperandWithVariable()
  [ADT] Fix signed integer overflow (llvm#155826)
  [Offload] Update LIBOMPTARGET_INFO text for `attach` map-type. (llvm#155509)
  [CMake][AIX] Enable CMP0182: Create shared library archives by default (llvm#155686)
  AMDGPU: Add tests for atomics with AGPR operands (llvm#155820)
  [AArch64] Split zero cycle zeoring per register class (llvm#154561)
  [gn build] Port fa883e1
  [mlir][tosa] Allow shift operand of tosa::MulOp as non-constant (llvm#155197)
  [AArch64][NFC] Add MCInstrAnalysis unittests (llvm#155609)
  [Offload][OpenMP] Tests require libc on GPU for printf (llvm#155785)
  AMDGPU: Add missing verifier tests for load/store AGPR case (llvm#155815)
  [lldb-mcp] Fix building for Windows
  Revert "[lldb] Correct a usage after a rename was merged. (llvm#155720)"
  Revert "[lldb] NFC Moving mcp::Transport into its own file. (llvm#155711)"
  [lldb][test] Run ranges::ref_vew test only for libc++ (llvm#155813)
  [SCCP][FuncSpec] Poison unreachable constant global variable user (llvm#155753)
  [LoongArch] Lowering v32i8 vector mask generation to `VMSKLTZ` (llvm#149953)
  [flang][docs][NFC] Remove stray backtick (llvm#154974)
  [MLIR] Apply clang-tidy fixes for misc-use-internal-linkage in LinalgOps.cpp (NFC)
  [MLIR] Apply clang-tidy fixes for performance-move-const-arg in VariantValue.cpp (NFC)
  ...
@amy-kwan amy-kwan added this to the LLVM 21.x Release milestone Sep 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Sep 2, 2025
@amy-kwan
Copy link
Contributor

amy-kwan commented Sep 2, 2025

This is is required to build AIX with the latest CMake versions.

/cherry-pick 94738dd

@llvmbot
Copy link
Member

llvmbot commented Sep 2, 2025

/pull-request #156504

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
Development

Successfully merging this pull request may close these issues.

4 participants