-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[MLIR][Python] enable type stub auto-generation #155741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
makslevental
wants to merge
20
commits into
main
Choose a base branch
from
users/makslevental/stubgen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+114
−3,187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12b9b37
to
b91ae20
Compare
b91ae20
to
7994333
Compare
aa2edbf
to
7dab1af
Compare
b7bbc85
to
44d8b56
Compare
44d8b56
to
0dc58fc
Compare
ba41789
to
4c67ba3
Compare
1163c12
to
4df87ae
Compare
makslevental
added a commit
that referenced
this pull request
Aug 31, 2025
Fix some things in `standalone` in order to unblock #155741.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 31, 2025
Fix some things in `standalone` in order to unblock llvm/llvm-project#155741.
010201c
to
9fe2cb4
Compare
9fe2cb4
to
386009c
Compare
386009c
to
62a9f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on automatic type stub generation (rather than relying on hand-written/updated stubs). It uses nanobind's stubgen facility.
Note, the only catch is we need a quite recent version of that code - specifically we need a commit of nanobind that includes wjakob/nanobind@53dce4e. In conventional
requirements.txt
files it's no issue to depend directly on a GitHub git commit (which I've done formlir/python/requirements.txt
) but such dependencies don't supportpip hash
(ironically). To workaround this I've temporarily updated.ci/monolithic-linux.sh
and.ci/monolithic-windows.sh
to explicitly install the appropriate commit of nanobind for our CI. When nanobind does its next PyPI release (which will contain the required53dce4e
commit), I'll updatemlir/python/requirements.txt
and.ci/all_requirements.txt
and restore the monolithic scripts.