[MLIR][Python] fix operation hashing #156514
Merged
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
users/makslevental/fix-op-hash
branch
from
97f80e5 to
2df299d
Compare
makslevental
requested review from
rolfmorel,
ftynse and
stellaraccident
as code owners
|
cc @Cubevoid can you double check this fixes you downstream |
|
I'll wait to merge on @Cubevoid confirming this fixes their issue. |
|
Thanks, this fixes the dict issue for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#155114 broke op hashing (because the python objects ceased to be reference equivalent). This PR fixes by binding
OperationEquivalence::computeHash.