[OMPIRBuilder] Use target global AS for SrcLocStr #156520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
jhuber6
approved these changes
Sep 2, 2025
| SrcLocStr = Builder.CreateGlobalString(LocStr, /* Name */ "", | ||
| /* AddressSpace */ 0, &M); | ||
| SrcLocStr = Builder.CreateGlobalString( | ||
| LocStr, /* Name */ "", |
There was a problem hiding this comment.
Suggested change
| LocStr, /* Name */ "", | |
| LocStr, /*Name=*/ "", |
Signed-off-by: Sarnie, Nick <[email protected]>
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Sarnie, Nick <[email protected]>
Yep, SPIR-V is really strict with AS. These usage here is specifying target AS so it should be language-independent. The rules should be the same across all source languages when using the same SPIR-V target so mixing IR should work, but I do doubt they are implemented correctly in all cases. If we see some problems I can add a triple check or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set the correct target-specific AS for the SrcLocStr global created in OMPIRBuilder.
We also may have to insert a constexpr addrspacecast because the struct field type may be different than the value used to initialize it.
I actually want the cast to be from AS 1 to AS 4, but getting the type to be AS4 relies on a PR currently in-review, so leave the cast target to AS 0 for now.