[HLSL] OVE as a subexpression of an OVE is not properly handled

[s-perron]

HLSL special cases the handling of OpaqueValueExpr (OVE) when it appears in an InitExpr. This special casing assumes that the OVE will not have a subexpression that is an OVE. After #156075 is merged, that will not be true for the test clang/test/CodeGenHLSL/resources/res-array-local-multi-dim.hlsl, and it starts to fail with an assert because the code tries to use the sub OVE before it is bound.

[llvmbot]

@llvm/issue-subscribers-clang-codegen

Author: Steven Perron (s-perron)

HLSL special cases the handling of OpaqueValueExpr (OVE) when it appears in an InitExpr. This special casing assumes that the OVE will not have a subexpression that is an OVE. After https://github.com//pull/156075 is merged, that will not be true for the test clang/test/CodeGenHLSL/resources/res-array-local-multi-dim.hlsl, and it starts to fail with an assert because the code tries to use the sub OVE before it is bound.