[llvm] Use lit internal shell by default #157237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
|
✅ With the latest revision this PR passed the Python code formatter. |
ilovepi
approved these changes
Sep 6, 2025
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
petrhosek
approved these changes
Sep 9, 2025
Created using spr 1.3.6 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Sep 9, 2025
This should result in a 10-15% test time improvement and also richer test failure outputn on Linux where it is not yet the default. We can do this now that all of the tests have been ported over to work with lit's internal shell. Fixes llvm#102697. Pull Request: llvm#157237
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
boomanaiden154
changed the base branch from
users/boomanaiden154/main.llvm-use-lit-internal-shell-by-default
to
main
boomanaiden154
deleted the
users/boomanaiden154/llvm-use-lit-internal-shell-by-default
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 10, 2025
This should result in a 10-15% test time improvement and also richer test failure outputn on Linux where it is not yet the default. We can do this now that all of the tests have been ported over to work with lit's internal shell. Fixes #102697. Reviewers: ilovepi, petrhosek Reviewed By: ilovepi, petrhosek Pull Request: llvm/llvm-project#157237
|
With the internal shell originally introduce to not require GnuWin32 on Windows, and now being the preferred way, is there any reason to disable the internal shell? If not, should we remove the external shell support? |
That's my eventual plan. There's still some work to be done. Patches are in flight to enable for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should result in a 10-15% test time improvement and also richer
test failure outputn on Linux where it is not yet the default. We can do
this now that all of the tests have been ported over to work with lit's
internal shell.
Fixes #102697.