Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

A left shift of (uintptr_t)-1) is simpler.

A left shift of (uintptr_t)-1) is simpler.
@llvmbot
Copy link
Member

llvmbot commented Sep 12, 2025

@llvm/pr-subscribers-llvm-adt

Author: Kazu Hirata (kazutakahirata)

Changes

A left shift of (uintptr_t)-1) is simpler.


Full diff: https://github.com/llvm/llvm-project/pull/158210.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/PointerIntPair.h (+1-2)
diff --git a/llvm/include/llvm/ADT/PointerIntPair.h b/llvm/include/llvm/ADT/PointerIntPair.h
index 9cfc65846d5bf..8acc2cf2d4f07 100644
--- a/llvm/include/llvm/ADT/PointerIntPair.h
+++ b/llvm/include/llvm/ADT/PointerIntPair.h
@@ -173,8 +173,7 @@ struct PointerIntPairInfo {
                 "PointerIntPair with integer size too large for pointer");
   enum MaskAndShiftConstants : uintptr_t {
     /// PointerBitMask - The bits that come from the pointer.
-    PointerBitMask =
-        ~(uintptr_t)(((intptr_t)1 << PtrTraits::NumLowBitsAvailable) - 1),
+    PointerBitMask = ((uintptr_t)-1) << PtrTraits::NumLowBitsAvailable,
 
     /// IntShift - The number of low bits that we reserve for other uses, and
     /// keep zero.

@kazutakahirata kazutakahirata merged commit bd7c2f1 into llvm:main Sep 12, 2025
8 of 9 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250911_ADT_PointerIntPair_PointerBitMask branch September 12, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants