[CIR][NFC] Remove Covered MissingFeatures flags for Complex #158425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmrDeveloper
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
llvmbot
added
clang
|
@llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) ChangesRemove Covered MissingFeatures flags for Complex Full diff: https://github.com/llvm/llvm-project/pull/158425.diff 3 Files Affected:
diff --git a/clang/include/clang/CIR/MissingFeatures.h b/clang/include/clang/CIR/MissingFeatures.h
index 52d5f8a2ded2c..60e0aa163dc04 100644
--- a/clang/include/clang/CIR/MissingFeatures.h
+++ b/clang/include/clang/CIR/MissingFeatures.h
@@ -296,8 +296,6 @@ struct MissingFeatures {
// Future CIR operations
static bool awaitOp() { return false; }
static bool callOp() { return false; }
- static bool complexImagOp() { return false; }
- static bool complexRealOp() { return false; }
static bool ifOp() { return false; }
static bool invokeOp() { return false; }
static bool labelOp() { return false; }
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
index 24aef693024f7..8918eb4cbb1ad 100644
--- a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
+++ b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -1754,9 +1754,6 @@ LogicalResult cir::BinOp::verify() {
return emitError() << "The nsw/nuw flags and the saturated flag are "
"mutually exclusive";
- assert(!cir::MissingFeatures::complexType());
- // TODO(cir): verify for complex binops
-
return mlir::success();
}
diff --git a/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp b/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
index d41ea0af58938..fbecab9774f5b 100644
--- a/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
+++ b/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
@@ -134,8 +134,6 @@ void CIRCanonicalizePass::runOnOperation() {
getOperation()->walk([&](Operation *op) {
assert(!cir::MissingFeatures::switchOp());
assert(!cir::MissingFeatures::tryOp());
- assert(!cir::MissingFeatures::complexRealOp());
- assert(!cir::MissingFeatures::complexImagOp());
assert(!cir::MissingFeatures::callOp());
// Many operations are here to perform a manual `fold` in
|
|
@llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) ChangesRemove Covered MissingFeatures flags for Complex Full diff: https://github.com/llvm/llvm-project/pull/158425.diff 3 Files Affected:
diff --git a/clang/include/clang/CIR/MissingFeatures.h b/clang/include/clang/CIR/MissingFeatures.h
index 52d5f8a2ded2c..60e0aa163dc04 100644
--- a/clang/include/clang/CIR/MissingFeatures.h
+++ b/clang/include/clang/CIR/MissingFeatures.h
@@ -296,8 +296,6 @@ struct MissingFeatures {
// Future CIR operations
static bool awaitOp() { return false; }
static bool callOp() { return false; }
- static bool complexImagOp() { return false; }
- static bool complexRealOp() { return false; }
static bool ifOp() { return false; }
static bool invokeOp() { return false; }
static bool labelOp() { return false; }
diff --git a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
index 24aef693024f7..8918eb4cbb1ad 100644
--- a/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
+++ b/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
@@ -1754,9 +1754,6 @@ LogicalResult cir::BinOp::verify() {
return emitError() << "The nsw/nuw flags and the saturated flag are "
"mutually exclusive";
- assert(!cir::MissingFeatures::complexType());
- // TODO(cir): verify for complex binops
-
return mlir::success();
}
diff --git a/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp b/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
index d41ea0af58938..fbecab9774f5b 100644
--- a/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
+++ b/clang/lib/CIR/Dialect/Transforms/CIRCanonicalize.cpp
@@ -134,8 +134,6 @@ void CIRCanonicalizePass::runOnOperation() {
getOperation()->walk([&](Operation *op) {
assert(!cir::MissingFeatures::switchOp());
assert(!cir::MissingFeatures::tryOp());
- assert(!cir::MissingFeatures::complexRealOp());
- assert(!cir::MissingFeatures::complexImagOp());
assert(!cir::MissingFeatures::callOp());
// Many operations are here to perform a manual `fold` in
|
xlauko
approved these changes
Sep 13, 2025
| "mutually exclusive"; | ||
|
|
||
| assert(!cir::MissingFeatures::complexType()); | ||
| // TODO(cir): verify for complex binops |
There was a problem hiding this comment.
It added here because in the incubator, BitOp handle addition and subtraction for the Complex type, but we changed that to introduce ComplexAddOp, ComplexSubOp
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/16057 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Covered MissingFeatures flags for Complex