[Clang] Make rewrite-includes-bom.c work with internal shell #158463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
|
@llvm/pr-subscribers-clang Author: Aiden Grossman (boomanaiden154) ChangesThis test was using $'<content with escapes' to have bash interpret Full diff: https://github.com/llvm/llvm-project/pull/158463.diff 1 Files Affected:
diff --git a/clang/test/Frontend/rewrite-includes-bom.c b/clang/test/Frontend/rewrite-includes-bom.c
index caa431ad9aaff..059cfa3be5bc8 100644
--- a/clang/test/Frontend/rewrite-includes-bom.c
+++ b/clang/test/Frontend/rewrite-includes-bom.c
@@ -1,8 +1,7 @@
-// RUN: grep -q $'^\xEF\xBB\xBF' %S/Inputs/rewrite-includes-bom.h
+// RUN: cat %S/Inputs/rewrite-includes-bom.h | od -t x1 | grep -q 'ef bb bf'
// RUN: %clang_cc1 -E -frewrite-includes -I %S/Inputs %s -o %t.c
-// RUN: ! grep -q $'\xEF\xBB\xBF' %t.c
+// RUN: cat %t.c | od -t x1 | not grep -q 'ef bb bf'
// RUN: %clang_cc1 -fsyntax-only -verify %t.c
// expected-no-diagnostics
-// REQUIRES: shell
#include "rewrite-includes-bom.h"
|
ilovepi
approved these changes
Sep 15, 2025
petrhosek
approved these changes
Sep 15, 2025
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Sep 19, 2025
This test was using $'<content with escapes' to have bash interpret shell escapes and then passing them to grep. The lexer/parser for lit's internal shell does not support such sequences. Given this is the only test in-tree that uses this functionality, it makes much more sense to use a POSIX compliant utility like od to transform the file into hex and then grep over that rather than modify the internal shell. This test should remain portable as od should be widely available and we are only using options specified in POSIX. Pull Request: llvm#158463
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.clang-make-rewrite-includes-bomc-work-with-internal-shell
to
main
boomanaiden154
deleted the
users/boomanaiden154/clang-make-rewrite-includes-bomc-work-with-internal-shell
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 20, 2025
This test was using $'<content with escapes' to have bash interpret shell escapes and then passing them to grep. The lexer/parser for lit's internal shell does not support such sequences. Given this is the only test in-tree that uses this functionality, it makes much more sense to use a POSIX compliant utility like od to transform the file into hex and then grep over that rather than modify the internal shell. This test should remain portable as od should be widely available and we are only using options specified in POSIX. Reviewers: cmtice, petrhosek, ilovepi Reviewed By: petrhosek, ilovepi Pull Request: llvm/llvm-project#158463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was using $'<content with escapes' to have bash interpret
shell escapes and then passing them to grep. The lexer/parser for lit's
internal shell does not support such sequences. Given this is the only
test in-tree that uses this functionality, it makes much more sense to
use a POSIX compliant utility like od to transform the file into hex and
then grep over that rather than modify the internal shell. This test
should remain portable as od should be widely available and we are only
using options specified in POSIX.