llvm-mca: Error on MCSubtargetInfo construction failure

[arsenm]

Replace assert with a handled error. The same should probably
be done for all of the MC constructors.

[arsenm]

• llvm-mca: Error on MCSubtargetInfo construction failure #159215 👈 (View in Graphite)
• llvm-mca: Remove unnecessary reconstruction of Triple #159213
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-tools-llvm-mca

Author: Matt Arsenault (arsenm)

Changes

Replace assert with a handled error. The same should probably
be done for all of the MC constructors.

---

Full diff: https://github.com/llvm/llvm-project/pull/159215.diff

1 Files Affected:

• (modified) llvm/tools/llvm-mca/llvm-mca.cpp (+5-1)

diff --git a/llvm/tools/llvm-mca/llvm-mca.cpp b/llvm/tools/llvm-mca/llvm-mca.cpp
index c969340742c39..a04b6ee9d90cf 100644
--- a/llvm/tools/llvm-mca/llvm-mca.cpp
+++ b/llvm/tools/llvm-mca/llvm-mca.cpp
@@ -413,7 +413,11 @@ int main(int argc, char **argv) {
 
   std::unique_ptr<MCSubtargetInfo> STI(
       TheTarget->createMCSubtargetInfo(TheTriple, MCPU, FeaturesStr));
-  assert(STI && "Unable to create subtarget info!");
+  if (!STI) {
+    WithColor::error() << "unable to create subtarget info\n";
+    return 1;
+  }
+
   if (!STI->isCPUStringValid(MCPU))
     return 1;