[clang] Remove redundant conditions (NFC) #159349
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A || (!A && B) => A || B
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: None (hstk30-hw) ChangesA || (!A && B) => A || B Full diff: https://github.com/llvm/llvm-project/pull/159349.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp
index 29193e0c541b9..4e735f6d28f34 100644
--- a/clang/lib/CodeGen/CGDecl.cpp
+++ b/clang/lib/CodeGen/CGDecl.cpp
@@ -1251,8 +1251,7 @@ void CodeGenFunction::emitStoresForConstant(const VarDecl &D, Address Loc,
LangOptions::TrivialAutoVarInitKind::Pattern;
if (shouldSplitConstantStore(CGM, ConstantSize)) {
if (auto *STy = dyn_cast<llvm::StructType>(Ty)) {
- if (STy == Loc.getElementType() ||
- (STy != Loc.getElementType() && IsTrivialAutoVarInitPattern)) {
+ if (STy == Loc.getElementType() || IsTrivialAutoVarInitPattern) {
const llvm::StructLayout *Layout =
CGM.getDataLayout().getStructLayout(STy);
for (unsigned i = 0; i != constant->getNumOperands(); i++) {
@@ -1266,8 +1265,7 @@ void CodeGenFunction::emitStoresForConstant(const VarDecl &D, Address Loc,
return;
}
} else if (auto *ATy = dyn_cast<llvm::ArrayType>(Ty)) {
- if (ATy == Loc.getElementType() ||
- (ATy != Loc.getElementType() && IsTrivialAutoVarInitPattern)) {
+ if (ATy == Loc.getElementType() || IsTrivialAutoVarInitPattern) {
for (unsigned i = 0; i != ATy->getNumElements(); i++) {
Address EltPtr = Builder.CreateConstGEP(
Loc.withElementType(ATy->getElementType()), i);
|
|
@llvm/pr-subscribers-clang-codegen Author: None (hstk30-hw) ChangesA || (!A && B) => A || B Full diff: https://github.com/llvm/llvm-project/pull/159349.diff 1 Files Affected:
diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp
index 29193e0c541b9..4e735f6d28f34 100644
--- a/clang/lib/CodeGen/CGDecl.cpp
+++ b/clang/lib/CodeGen/CGDecl.cpp
@@ -1251,8 +1251,7 @@ void CodeGenFunction::emitStoresForConstant(const VarDecl &D, Address Loc,
LangOptions::TrivialAutoVarInitKind::Pattern;
if (shouldSplitConstantStore(CGM, ConstantSize)) {
if (auto *STy = dyn_cast<llvm::StructType>(Ty)) {
- if (STy == Loc.getElementType() ||
- (STy != Loc.getElementType() && IsTrivialAutoVarInitPattern)) {
+ if (STy == Loc.getElementType() || IsTrivialAutoVarInitPattern) {
const llvm::StructLayout *Layout =
CGM.getDataLayout().getStructLayout(STy);
for (unsigned i = 0; i != constant->getNumOperands(); i++) {
@@ -1266,8 +1265,7 @@ void CodeGenFunction::emitStoresForConstant(const VarDecl &D, Address Loc,
return;
}
} else if (auto *ATy = dyn_cast<llvm::ArrayType>(Ty)) {
- if (ATy == Loc.getElementType() ||
- (ATy != Loc.getElementType() && IsTrivialAutoVarInitPattern)) {
+ if (ATy == Loc.getElementType() || IsTrivialAutoVarInitPattern) {
for (unsigned i = 0; i != ATy->getNumElements(); i++) {
Address EltPtr = Builder.CreateConstGEP(
Loc.withElementType(ATy->getElementType()), i);
|
cor3ntin
approved these changes
Sep 17, 2025
antoniofrighetto
approved these changes
Sep 17, 2025
antoniofrighetto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A || (!A && B) => A || B