Skip to content

Conversation

kr-2003
Copy link
Contributor

@kr-2003 kr-2003 commented Sep 17, 2025

No description provided.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 17, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 17, 2025

@llvm/pr-subscribers-clang

Author: Abhinav Kumar (kr-2003)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/159404.diff

1 Files Affected:

  • (modified) clang/unittests/Interpreter/CMakeLists.txt (+2-2)
diff --git a/clang/unittests/Interpreter/CMakeLists.txt b/clang/unittests/Interpreter/CMakeLists.txt
index 7b8dcfc9b0546..66b396b53cb55 100644
--- a/clang/unittests/Interpreter/CMakeLists.txt
+++ b/clang/unittests/Interpreter/CMakeLists.txt
@@ -37,7 +37,7 @@ set(CLANG_REPL_TEST_SOURCES
   CodeCompletionTest.cpp
 )
 
-if(TARGET compiler-rt)
+if(TARGET compiler-rt AND LLVM_ON_UNIX)
   list(APPEND CLANG_REPL_TEST_SOURCES
     OutOfProcessInterpreterTests.cpp
   )
@@ -61,7 +61,7 @@ add_distinct_clang_unittest(ClangReplInterpreterTests
   ${LLVM_COMPONENTS_TO_LINK}
   )
 
-if(TARGET compiler-rt)
+if(TARGET compiler-rt AND LLVM_ON_UNIX)
   add_dependencies(ClangReplInterpreterTests 
     llvm-jitlink-executor 
     compiler-rt

@kr-2003
Copy link
Contributor Author

kr-2003 commented Sep 17, 2025

@OCHyams Can you review this?

Copy link
Contributor

@OCHyams OCHyams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to get the build fixed (works locally for me)

I am not familiar with the test or what it's testing, so I can't weigh in as to whether there should also be a windows version of the test.

Thanks for the speedy fix.

Copy link
Member

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OCHyams

Thanks for the review. Yes we don't expect this to work on Windows !

@vgvassilev vgvassilev merged commit 3044549 into llvm:main Sep 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants