[flang] Disable -gdwarf-5 tests on AIX. #159533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang:driver
flang
|
@llvm/pr-subscribers-flang-driver Author: Abid Qadeer (abidh) ChangesAfter recent addition of -gdwarf-N options in flang, I saw that newly added tests failing on AIX bot. The gdwarf-5 option is not supported on that platform. Disabling the test on AIX for now. Full diff: https://github.com/llvm/llvm-project/pull/159533.diff 2 Files Affected:
diff --git a/flang/test/Driver/flang-dwarf-version.f90 b/flang/test/Driver/flang-dwarf-version.f90
index dc69140a7eda1..159130aaed98c 100644
--- a/flang/test/Driver/flang-dwarf-version.f90
+++ b/flang/test/Driver/flang-dwarf-version.f90
@@ -1,3 +1,4 @@
+// UNSUPPORTED: target={{.*}}-aix{{.*}}
// RUN: %flang -### -S %s -g -gdwarf-5 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-DWARF5 %s
// RUN: %flang -### -S %s -gdwarf-5 2>&1 \
diff --git a/flang/test/Integration/debug-dwarf-flags.f90 b/flang/test/Integration/debug-dwarf-flags.f90
index ac5b1c0d8d4b2..9de1dc8163653 100644
--- a/flang/test/Integration/debug-dwarf-flags.f90
+++ b/flang/test/Integration/debug-dwarf-flags.f90
@@ -1,3 +1,4 @@
+// UNSUPPORTED: target={{.*}}-aix{{.*}}
! RUN: %flang_fc1 -emit-llvm -debug-info-kind=standalone -dwarf-version=5 %s \
! RUN: -o - | FileCheck --check-prefix=CHECK-DWARF5 %s
! RUN: %flang_fc1 -emit-llvm -debug-info-kind=line-tables-only -dwarf-version=5 \
|
tarunprabhu
reviewed
Sep 18, 2025
There was a problem hiding this comment.
If only dwarf-version=5 is not supported, it may be better to just disable those tests rather than all of them. Perhaps something like this?
Suggested change
| // UNSUPPORTED: target={{.*}}-aix{{.*}} | |
| // RUN: %if !target={{.*aix.*}} %{ \ | |
| // RUN: %flang -### -S %s -g -gdwarf-5 2>&1 \ | |
| // RUN: | FileCheck --check-prefix=CHECK-DWARF5 %s \ | |
| // RUN: %} | |
| // RUN: %if !target={{.*aix.*}} %{ \ | |
| // RUN: %flang -### -S %s -gdwarf-5 2>&1 \ | |
| // RUN: | FileCheck --check-prefix=CHECK-DWARF5 %s \ | |
| // RUN: %} | |
| // RUN: %if !target={{.*aix.*}} %{ \ | |
| // RUN: %flang -### -S %s -g1 -gdwarf-5 2>&1 \ | |
| // RUN: | FileCheck --check-prefix=CHECK-WITH-G1-DWARF5 %s``` \ | |
| // RUN: %} |
There was a problem hiding this comment.
Thanks for the suggestion. Done.
|
The CI failure is due to an unrelated issue which is being fixed in #159604. |
Put the check for aix only around dwarf5 tests. This way rest of the tests run for aix too.
|
If there are no objections then I would like to merge this. It should turn the https://lab.llvm.org/buildbot/#/builders/201 bot green. |
tarunprabhu
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent addition of -gdwarf-N options in flang, I saw that newly added tests failing on AIX bot. The gdwarf-5 option is not supported on that platform. Disabling the test on AIX for now.