[TEST][WIP] Run clang-tidy inside ci-container #160193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-github-workflow Author: Baranov Victor (vbvictor) ChangesWIP, do not review Full diff: https://github.com/llvm/llvm-project/pull/160193.diff 1 Files Affected:
diff --git a/.github/workflows/pr-code-lint.yml b/.github/workflows/pr-code-lint.yml
index bc70933147bd2..3efd75471a317 100644
--- a/.github/workflows/pr-code-lint.yml
+++ b/.github/workflows/pr-code-lint.yml
@@ -47,10 +47,13 @@ jobs:
echo "Changed files:"
echo "$CHANGED_FILES"
+ # The clang tidy version should always be upgraded to the first version
+ # of a release cycle (x.1.0) or the last version of a release cycle, or
+ # if there have been relevant clang-format backports.
- name: Install clang-tidy
uses: aminya/setup-cpp@17c11551771948abc5752bbf3183482567c7caf0 # v1.1.1
with:
- clang-tidy: 20.1.8
+ clang-tidy: 21.1.0
- name: Setup Python env
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
|
You can test this locally with the following command:git diff -U0 origin/main...HEAD -- clang-tools-extra/clang-tidy/ClangTidy.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py \
-path build -p1 -quietView the output from clang-tidy here. |
vbvictor
force-pushed
the
fix-clang-tidy-ci
branch
from
c5f8ae9 to
aeeb181
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
vbvictor
force-pushed
the
fix-clang-tidy-ci
branch
from
182ca8e to
1ce93d7
Compare
vbvictor
changed the title
|
✅ With the latest revision this PR passed the Python code formatter. |
Contributor
|
This is just a duplicate of #161073? |
Contributor
Author
Yes, I'm testing how everything works here |
vbvictor
changed the title
vbvictor
force-pushed
the
fix-clang-tidy-ci
branch
from
2f6203c to
f5900e2
Compare
vbvictor
changed the title
vbvictor
force-pushed
the
fix-clang-tidy-ci
branch
from
48dce39 to
732b4ca
Compare
vbvictor
added a commit
that referenced
this pull request
Oct 20, 2025
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing ground do not review!