-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[GitHub][docker] Add python3 venv package to CI container #161024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@llvm/pr-subscribers-github-workflow Author: Baranov Victor (vbvictor) ChangesI'm trying to make FYI I hacked test-run with Full diff: https://github.com/llvm/llvm-project/pull/161024.diff 1 Files Affected:
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index 1d3f5f9c35d7f..dc0c9cabc7f01 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -62,6 +62,7 @@ RUN apt-get update && \
# Having a symlink from python to python3 enables code sharing between
# the Linux and Windows pipelines.
python3-pip \
+ python3-venv \
file \
tzdata \
python-is-python3 && \
|
boomanaiden154
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think we want to eventually move to separate containers for the clang-format/premerge/clang-tidy workflows to trim down on space (and preinstall necessary python dependencies), but this seems fine for now, especially since the premerge container already has clang-format/clang-tidy.
It actually doesn't have clang-tidy installed. I tried building with clanf-tidy locally and got 1.1GB -> 1.2GB image size. So as the first Iteration I think the 100mb increase is ok |
I'm trying to make `pr-code-format.yml` job run natively on `ci-ubuntu-24.04` container. As it appears, `ci-ubuntu-24.04` already [has](https://github.com/llvm/llvm-project/blob/41a2dfc0d77d9ad977d1d36358f979abb3a0928f/.github/workflows/containers/github-action-ci/Dockerfile#L35) latest `clang-format`, `python3.12` installed, but `python3.12` needs `venv` to work properly, and Ubuntu asks for `python3-venv` package to be installed to create a venv.
…vm#161024)" This reverts commit 5a13c85. Now that pr-code-format.yml will be using a purpose-built container, we no longer need support for this in the main CI container.
…vm#161024)" This reverts commit 5a13c85. Now that pr-code-format.yml will be using a purpose-built container, we no longer need support for this in the main CI container.
I'm trying to make
pr-code-format.ymljob run natively onci-ubuntu-24.04container.As it appears,
ci-ubuntu-24.04already has latestclang-format,python3.12installed, butpython3.12needsvenvto work properly, and Ubuntu asks forpython3-venvpackage to be installed to create a venv.FYI I hacked it with
--break-system-packagesto test and clang-format job runs a lot faster https://github.com/llvm/llvm-project/actions/runs/18064896361/job/51406365488#logs (skipping 1min longclang-formatinstallation). Just don't look at "Initialize containers" taking 6min, it usually takes 15-20sec